Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memory limit of kube-state-metrics to 600Mi #12692

Merged

Conversation

al-lac
Copy link
Contributor

@al-lac al-lac commented Oct 9, 2023

What this PR does / why we need it:

It increases the memory limit for the kube-state-metrics addon to 600Mi

Bigger clusters with a lot of namespaces and metrics have an increased memory usage for the kube-state-metrics pods which results in OOM kills. The increased limit makes it possible to use the addon on bigger clusters.

Which issue(s) this PR fixes:

Fixes #12689, kind of

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Increase memory limit of kube-state-metrics addon to 600Mi

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2023
@kubermatic-bot
Copy link
Contributor

Hi @al-lac. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2023
@embik
Copy link
Member

embik commented Oct 11, 2023

@al-lac commit will need to be DCO signed, see this comment by our bot.

Signed-off-by: al-lac <lackner.alex@gmail.com>
@al-lac al-lac force-pushed the kube-state-metrics-memory-limit branch from a8e9fc5 to d3eae19 Compare October 11, 2023 14:04
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Oct 11, 2023
@embik
Copy link
Member

embik commented Oct 12, 2023

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2023
@xrstf xrstf self-assigned this Oct 12, 2023
@xrstf
Copy link
Contributor

xrstf commented Oct 12, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07a06880a4a3ba863ad80ed63421563c16a9ec24

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@kubermatic-bot kubermatic-bot merged commit 604ffa6 into kubermatic:main Oct 12, 2023
12 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Oct 12, 2023
@al-lac al-lac deleted the kube-state-metrics-memory-limit branch October 13, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom container limits for addons like kube-state-metrics
4 participants