-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop throttling KKP controllers #12764
Conversation
Nit: Let's add information to what new limits we are updating in the release note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: d4f74e850b254e5b2f50f4689e52844b21606a4f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history Silence the bot with an |
/override pre-kubermatic-test-integration |
@xrstf: Overrode contexts on behalf of xrstf: pre-kubermatic-test-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Review the full test history Silence the bot with an |
1 similar comment
/retest Review the full test history Silence the bot with an |
/cherrypick release/v2.23 |
/cherrypick release/v2.22 |
/cherrypick release/v2.21 |
@xrstf: new pull request created: #12769 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xrstf: new pull request created: #12770 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xrstf: #12764 failed to apply on top of branch "release/v2.21":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The resource constraints for KKP seed/master controllers are ancient. I (apparently) set them in #3012, a time when there wasn't even a master-controller-manager, but only an "rbac generator". "100m" might have been a useful limit for something that generates RBAC only, but the master-ctrl-mgr nowadays does way more.
We have observed it hitting the 100m CPU limit very often, to a point where even
warnings were logged.
This PR raises the limit considerably, which should make KKP reconciliations much smoother.
What type of PR is this?
/kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: