Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update velero's helm chart apiversion to v2 #12765

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Update velero's helm chart apiversion to v2 #12765

merged 1 commit into from
Oct 22, 2023

Conversation

akash-gautam
Copy link
Contributor

@akash-gautam akash-gautam commented Oct 20, 2023 •
edited by xrstf

What this PR does / why we need it:
We tried installing the velero helm chart using Argocd on seed but the CRDs were not getting picked by argocd as it needs the chart's apiversion to be v2 for that. Most of the community helm charts including velero are already using v2 & many charts in the Kubermatic's charts folder are also using v2 so we can/should update this as well.
What type of PR is this?

Optionally add one or more of the following kinds if applicable:
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Update Velero helm chart's apiVersion to v2; Helm 3 & above would be required to install it.

Documentation:

NONE

@akash-gautam
update velero's helm chart apiversion to v2
f5d4ae9 
Signed-off-by: Akash Gautam <gautamakash04@gmail.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2023
@embik
Copy link
Member

embik commented Oct 20, 2023

This should have a release note, please add one.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 20, 2023
xrstf
xrstf approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f1778265debcb95f8657f05a9e8f36d9da2dcf4e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2023
@xrstf xrstf added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Oct 21, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Oct 21, 2023
@embik embik added this to the KKP 2.24 milestone Oct 22, 2023
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit c9d9eae into kubermatic:main Oct 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akash-gautam @embik @kubermatic-bot @kubermatic-triage-bot @xrstf