Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.23] Extend project-synchronizer to sync labels #12792

Merged
merged 1 commit into from
Oct 27, 2023
Merged

[release/v2.23] Extend project-synchronizer to sync labels #12792

merged 1 commit into from
Oct 27, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 26, 2023

What this PR does / why we need it:

Manual cherry-pick of #12791 to the release/v2.23 branch

What type of PR is this?

/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Extend project-synchronizer controller in kubermatic-master-controller-manager to propagate labels from Projects in the master cluster to Projects in the seed cluster. This fixes an issue where the metering report doesn't contain project-labels in separate master/seed setups

Documentation:

NONE

/assign @xrstf

@xmudrii
Extend project-synchronizer to sync labels
c3a150f 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from xrstf October 26, 2023 17:08
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 26, 2023
@kubermatic-bot kubermatic-bot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 26, 2023
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Oct 26, 2023
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2023
@xmudrii xmudrii mentioned this pull request Oct 26, 2023
Merged
@xrstf
Copy link
Contributor

xrstf commented Oct 27, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73c23d7dee2a914ff6c96698f1904a04a2e75f29

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@xrstf xrstf added the cherry-pick-approved Indicates a PR has been approved by release managers. label Oct 27, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 27, 2023
@kubermatic-bot kubermatic-bot merged commit 9dde9cc into kubermatic:release/v2.23 Oct 27, 2023
17 checks passed
@xmudrii xmudrii deleted the project-sync-labels-2.23 branch October 27, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xmudrii @xrstf @kubermatic-bot