Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use regex for hostnames in seed MLA dashboard "Resource Usage per Namespace" #12816

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Use regex for hostnames in seed MLA dashboard "Resource Usage per Namespace" #12816

merged 1 commit into from
Nov 3, 2023

Conversation

embik
Copy link
Member

@embik embik commented Nov 3, 2023

What this PR does / why we need it:
The "Resource Usage per Namespace" dashboard in our Seed MLA stack supports selecting multiple hosts (and defaults to the "all" option). Some queries were not using the $hostname variable as regex, and were therefore failing for every selection except a single host.

This was initially reported to us in INC-6148.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix empty panels in Grafana dashboard "Resource Usage per Namespace" for Master/Seed MLA

Documentation:

NONE

@embik
Fix queries for hostnames
47c1dbb 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik added this to the KKP 2.24 milestone Nov 3, 2023
@embik embik requested a review from wurbanski November 3, 2023 15:02
@embik embik self-assigned this Nov 3, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. labels Nov 3, 2023
@embik embik changed the title Fix queries for hostnames in seed MLA dashboard "Resource Usage per Namespace" Use regex for hostnames in seed MLA dashboard "Resource Usage per Namespace" Nov 3, 2023
@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2023
@wurbanski
Copy link
Contributor

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2cda6daeb4abedb1b0db5027047baee07af462bd

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wurbanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@embik embik added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Nov 3, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Nov 3, 2023
@kubermatic-bot kubermatic-bot merged commit 2e30b91 into kubermatic:main Nov 3, 2023
5 checks passed
@embik embik deleted the node-namespaces-seed-mla-fix branch November 3, 2023 15:33
@embik embik added the backport-needed Denotes a PR or issue that has not been fully backported. label Nov 6, 2023
@embik
Copy link
Member Author

embik commented Nov 9, 2023

/cherry-pick release/v2.23

@embik
Copy link
Member Author

embik commented Nov 9, 2023

/cherry-pick release/v2.22

@kubermatic-bot
Copy link
Contributor

@embik: new pull request created: #12832

In response to this:

/cherry-pick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Nov 9, 2023
Merged
@kubermatic-bot
Copy link
Contributor

@embik: #12816 failed to apply on top of branch "release/v2.22":

Applying: Fix queries for hostnames
Using index info to reconstruct a base tree...
M	charts/monitoring/grafana/dashboards/kubernetes/node-namespaces.json
Falling back to patching base and 3-way merge...
Auto-merging charts/monitoring/grafana/dashboards/kubernetes/node-namespaces.json
CONFLICT (content): Merge conflict in charts/monitoring/grafana/dashboards/kubernetes/node-namespaces.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix queries for hostnames
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

embik added a commit to embik/kubermatic that referenced this pull request Nov 9, 2023
@embik
[release/v2.22] Fix queries for hostnames (kubermatic#12816)
8dc2783 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik mentioned this pull request Nov 9, 2023
Merged
kubermatic-bot pushed a commit that referenced this pull request Nov 9, 2023
@embik
[release/v2.22] Fix queries for hostnames (#12816) (#12833)
1f9ace8 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik added backport-complete Denotes a PR or issue which has been fully backported to all required release branches. and removed backport-needed Denotes a PR or issue that has not been fully backported. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wurbanski wurbanski Awaiting requested review from wurbanski

Assignees

@wurbanski wurbanski

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@embik @wurbanski @kubermatic-bot