Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add K8sGpt as Default Application #13025

Merged
merged 1 commit into from Feb 2, 2024
Merged

Add K8sGpt as Default Application #13025

merged 1 commit into from Feb 2, 2024

Conversation

mfahlandt
Copy link
Contributor

@mfahlandt mfahlandt commented Feb 2, 2024 •
edited by archups

What this PR does / why we need it:

Which issue(s) this PR fixes:
#12994

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Add k8sgpt operator to the Default Application Catalogue

Documentation:

https://github.com/kubermatic/docs/pull/1610

@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2024
@scheeles
Copy link
Member

scheeles commented Feb 2, 2024

Can we add the CLI also to the Webterminal

@mfahlandt
Copy link
Contributor Author

I guess we can add it to the image that gets started - i would have it in a seperate pr / feature

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/retest

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 2, 2024
ahmedwaleedmalik
ahmedwaleedmalik reviewed Feb 2, 2024
View reviewed changes
pkg/ee/default-application-catalog/applicationdefinitions/k8sgpt-app.yaml Outdated
@@ -0,0 +1,53 @@
# Kubermatic Enterprise Read-Only License
# Version 1.0 ("KERO-1.0”)
# Copyright © 2023 Kubermatic GmbH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2023/2024

@ahmedwaleedmalik
Copy link
Member

/lgtm cancel

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1053ebd857b89b0d60841240d90be9c4ec30ad70

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit cb8de88 into kubermatic:main Feb 2, 2024
16 of 17 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Feb 2, 2024
@archups archups mentioned this pull request Feb 7, 2024
Merged
@csengerszabo csengerszabo mentioned this pull request Mar 5, 2024
Merged
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Mar 6, 2024
@xrstf xrstf mentioned this pull request Mar 8, 2024
Closed
@mfahlandt mfahlandt mentioned this pull request Mar 22, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mfahlandt @scheeles @ahmedwaleedmalik @kubermatic-bot