Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.24] fix panic if no KubeVirt DNS config was set (#12933) #13028

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[release/v2.24] fix panic if no KubeVirt DNS config was set (#12933) #13028

merged 1 commit into from
Feb 5, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Feb 5, 2024

What this PR does / why we need it:
This backports #12933.

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix panic if no KubeVirt DNS config was set in the datacenter.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 5, 2024
@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Feb 5, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. labels Feb 5, 2024
embik
embik approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1efbabd36f706f78f715eaede1d69a1a09acbd8c

@xrstf
Copy link
Contributor Author

xrstf commented Feb 5, 2024

@cnvergence PTAL

@xrstf xrstf requested a review from cnvergence February 5, 2024 09:50
@xrstf
Copy link
Contributor Author

xrstf commented Feb 5, 2024

@cnvergence need a /approve, a Github approval is counted as "LGTM" by prow. 😁

@cnvergence
Copy link
Member

/approve 🐦

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cnvergence, embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@embik embik added the cherry-pick-approved Indicates a PR has been approved by release managers. label Feb 5, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 5, 2024
@kubermatic-bot kubermatic-bot merged commit 9bbc5c9 into kubermatic:release/v2.24 Feb 5, 2024
19 checks passed
@xrstf xrstf deleted the backport-12933-2.24 branch February 5, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@cnvergence cnvergence cnvergence approved these changes

Assignees

@embik embik

@cnvergence cnvergence

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrstf @kubermatic-bot @cnvergence @embik