-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override hubble-ui images if overwriteRegistry is set #13139
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/cherry-pick release/v2.24 |
@embik: once the present PR merges, I will cherry-pick it on top of release/v2.24 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @cnvergence |
/milestone KKP 2.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LGTM label has been added. Git tree hash: ef8a69ccd53063be9b424ae7703b6da8a46dab28
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cnvergence The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@embik: new pull request created: #13140 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
As reported, the hubble-ui frontend and backend images are not correctly overridden if
overwriteRegistry
is set. Turns out, thevaluesFrontend
andvaluesBackend
variables prepared for it where never added to the mainvalues
map.To make this PR backport-compatible for 2.24, I am also not setting the podSecurityContext that would have been part of cloning the common values into
valuesFrontend
andvaluesBackend
. The value doesn't exist anyway.In addition, I have moved the construction of the final
values
map from the sub-maps to the end of the function. I found it deeply confusing that the maps are wired up intovalues
first and then set.Which issue(s) this PR fixes:
Fixes #13136
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: