Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude test folders from chart archive #13151

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: exclude test folders from chart archive #13151

merged 1 commit into from
Mar 6, 2024

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 6, 2024 •
edited
Loading

What this PR does / why we need it:

Excludes test folders which contain symlinks that break once the archive is untarred.

Which issue(s) this PR fixes:

Fixes #13142

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Exclude `test` folders which contain symlinks that break once the archive is untarred.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 6, 2024
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/provided Denotes a PR that has a valid documentation reference. labels Mar 6, 2024
@xrstf xrstf added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Mar 6, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Mar 6, 2024
@xrstf xrstf added this to the KKP 2.25 milestone Mar 6, 2024
xrstf
xrstf requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the EE tar command further down.

@Skarlso
fix: exclude test folders from chart archive
139f9f1 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 6, 2024

Updated. Thanks for the spot @xrstf!

@xrstf
Copy link
Contributor

xrstf commented Mar 6, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d843e420483df9d27fbbe46bdceb34f02b30137c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@kubermatic-bot kubermatic-bot merged commit d8a441a into kubermatic:main Mar 6, 2024
12 checks passed
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 6, 2024

/cherrypick release/v2.24

@kubermatic-bot
Copy link
Contributor

@Skarlso: new pull request created: #13153

In response to this:

/cherrypick release/v2.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 6, 2024
Merged
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 6, 2024

/cherrypick release/v2.23

@kubermatic-bot
Copy link
Contributor

@Skarlso: new pull request created: #13154

In response to this:

/cherrypick release/v2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 6, 2024
Merged
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 6, 2024

/cherrypick release/v2.22

@kubermatic-bot
Copy link
Contributor

@Skarlso: new pull request created: #13155

In response to this:

/cherrypick release/v2.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 6, 2024
Merged
@embik embik added the backport-complete Denotes a PR or issue which has been fully backported to all required release branches. label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf requested changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

IAP upgrade fails with no such file or directory for test.sh symlink
4 participants
@Skarlso @xrstf @kubermatic-bot @embik