Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CBSL reconcile issues #13179

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix CBSL reconcile issues #13179

merged 1 commit into from
Mar 14, 2024

Conversation

moelsayed
Copy link
Contributor

What this PR does / why we need it:
Fixes a couple of issues:

  • a bug in handling reconcile errors.
  • remove orphaned credentials secrets.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug
Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2024
embik
embik approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2352a4d809236d27ec10d7e3e479208367d560c4

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@embik
Copy link
Member

embik commented Mar 14, 2024

/milestone KKP 2.25

@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Mar 14, 2024
@embik embik added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Mar 14, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Mar 14, 2024
@kubermatic-bot kubermatic-bot merged commit 518f8aa into kubermatic:main Mar 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moelsayed @kubermatic-bot @embik