Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add velero and kubeLB images to the list of mirrored images #13192

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add velero and kubeLB images to the list of mirrored images #13192

merged 1 commit into from
Mar 20, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
We forgot to add KubeLB and Velero images to our mirrored images list.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add images for velero and kubeLB to mirrored images list

Documentation:

NONE

/cc @xrstf

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2024
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v2.25

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.25 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member Author

/hold
Needs some work

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@ahmedwaleedmalik
Add velero and kubeLB images to the list of mirrored images
b25daae 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2024
@ahmedwaleedmalik
Copy link
Member Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@xrstf
Copy link
Contributor

xrstf commented Mar 20, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da1e8e74e1f3f462365d92b70ced664dd4362545

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@kubermatic-bot kubermatic-bot merged commit 2c7feed into kubermatic:main Mar 20, 2024
16 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Mar 20, 2024
@kubermatic-bot kubermatic-bot mentioned this pull request Mar 20, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #13193

In response to this:

/cherry-pick release/v2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik ahmedwaleedmalik deleted the mirror-velero-kubelb branch March 20, 2024 20:28
ahmedwaleedmalik added a commit to ahmedwaleedmalik/kubermatic that referenced this pull request Mar 21, 2024
@ahmedwaleedmalik
Add velero and kubeLB images to the list of mirrored images (kubermat…
c4a5437 
…ic#13192)

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Mar 21, 2024
Merged
kubermatic-bot pushed a commit that referenced this pull request Mar 21, 2024
@ahmedwaleedmalik
Add velero and kubeLB images to the list of mirrored images (#13192) (#…
26354a5 
…13198)

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf