Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new kubermatic_cluster_owner metric #13194

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Mar 20, 2024

What this PR does / why we need it:
This PR adds a new metric that maps clusters to their owners. To prevent emails leaking into metrics, the emails are resolved to the KKP user, similar to how we do it for projects.

This metric can be useful for the metering component later on, to provide more detailed reports.

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Add new `kubermatic_cluster_owner` metric on seed clusters, with `cluster_name` and `user` labels.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
@xrstf xrstf self-assigned this Mar 20, 2024
@xrstf xrstf requested a review from dakraus March 20, 2024 22:46
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a3c37b6fcd133c012eaa61b21988d145596191b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@kubermatic-bot kubermatic-bot merged commit a8b549e into kubermatic:main Mar 25, 2024
16 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Mar 25, 2024
@xrstf xrstf deleted the include-user-in-metrics branch March 25, 2024 08:53
@xrstf
Copy link
Contributor Author

xrstf commented Mar 25, 2024

/cherrypick release/v2.25

@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #13216

In response to this:

/cherrypick release/v2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants