set release tag for minio/mc #13199
set release tag for minio/mc #13199
Conversation
Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>
kubermatic-bot
added
docs/none
|
Hi @JamesClonk. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubermatic-bot
added
the
size/XS
|
/assign @wurbanski |
|
/ok-to-test |
kubermatic-bot
added
ok-to-test
kubermatic-bot
added
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 8aec5a3a7be75b73834838d7183768c6b827272b
|
kubermatic-bot
added
the
approved
| @@ -14,7 +14,7 @@ | |||
| lifecycleMgr: | |||
| image: | |||
| repository: docker.io/minio/mc | |||
| tag: latest | |||
There was a problem hiding this comment.
can we use the version from the charts/mla/minio instead? That would be RELEASE.2023-04-28T18-11-17Z at this time
There was a problem hiding this comment.
That release does not seem to exist for minio/mc:
manifest for minio/mc:RELEASE.2023-04-28T18-11-17Z not found: manifest unknown: manifest unknown
There was a problem hiding this comment.
Personally I would not give much value on keeping mc on the same version as Minio. I would put more emphasis on adding a comment explaining why this value is overridden and that it is not this one magic specific version, but just "latest MC at the time of making the PR" or something.
There was a problem hiding this comment.
that makes sense to me. Agree with @xrstf - please put a comment explaining and it's fine by me.
There was a problem hiding this comment.
Where would I put this comment? Into the release notes?
There was a problem hiding this comment.
In the values.yaml, right above the line where we specify the mc image.
Signed-off-by: Fabio Berchtold <fabio.berchtold@swisscom.com>
kubermatic-bot
added
size/S
|
Thank you for the PR and your patience :-) /approve |
kubermatic-bot
added
lgtm
|
LGTM label has been added. Git tree hash: 155df231952bfa28db3c7a1fec84d14c145905e1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrrypick release/v2.25 |
|
/cherrypick release/v2.25 |
|
@xrstf: new pull request created: #13231 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR changes the tag in the mla/minio-lifecycle-mgr helm chart from
latesttoRELEASE.2024-03-13T23-51-57Z(which corresponds to latest at the time of this writing).Using
latestis problematic, as the underlying image and thus sha256 digest changes constantly and with each new release of minio/mc, not providing a stable and well defined version of the image. The change to a specific release tag will remove this unpredictability.What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: