Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated cilium and hubble addons #13229

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

cnvergence
Copy link
Member

What this PR does / why we need it:
Followup of #12848

Which issue(s) this PR fixes:

Fixes #11356

What type of PR is this?

/kind deprecation
Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

TBD

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 28, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2024
@cnvergence cnvergence marked this pull request as ready for review March 28, 2024 16:42
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@cnvergence
Copy link
Member Author

/assign

Signed-off-by: Karol Szwaj <karol@kubermatic.com>
Signed-off-by: Karol Szwaj <karol@kubermatic.com>
Signed-off-by: Karol Szwaj <karol@kubermatic.com>
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Please add a release note and update the docs as well, if required.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a378195ac188b108ea93586d764848dbccdc56e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@kubermatic-bot kubermatic-bot merged commit a182dfe into kubermatic:main Apr 4, 2024
18 of 19 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.26 milestone Apr 4, 2024
@cnvergence cnvergence deleted the remove-old-cilium branch April 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement controller for installing CNI as ApplicationInstallation
3 participants