Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.24] upgrade Canal to 3.27.3 (#13239) #13246

Merged
merged 2 commits into from Apr 8, 2024
Merged

[release/v2.24] upgrade Canal to 3.27.3 (#13239) #13246

merged 2 commits into from Apr 8, 2024

Conversation

cnvergence
Copy link
Member

What this PR does / why we need it:
Add Canal with an updated version, containing an important fix to ipset kernel module incompatibility.

Which issue(s) this PR fixes:

Fixes #13236

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add Canal CNI version v3.27.3, having a fix to the ipset incompatibility bug.

Documentation:

TBD

@kubermatic-bot kubermatic-bot added this to the KKP 2.24 milestone Apr 5, 2024
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 5, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/networking Denotes a PR or issue as being assigned to SIG Networking. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 5, 2024
@cnvergence cnvergence marked this pull request as ready for review April 5, 2024 14:52
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2024
@cnvergence
Copy link
Member Author

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b667080a5c3db5b63418d394d1caf0d5b9e66cce

cnvergence
cnvergence commented Apr 8, 2024
View reviewed changes
Copy link
Member Author

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@cnvergence
Copy link
Member Author

/assign ahmedwaleedmalik

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, cnvergence

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@embik embik added the cherry-pick-approved Indicates a PR has been approved by release managers. label Apr 8, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 8, 2024
@kubermatic-bot kubermatic-bot merged commit c3318ae into kubermatic:release/v2.24 Apr 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@embik embik

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/networking Denotes a PR or issue as being assigned to SIG Networking. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cnvergence @kubermatic-bot @embik @ahmedwaleedmalik