Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.23] Add ability to override OSM resources #13288

Merged
merged 3 commits into from
Apr 12, 2024
Merged

[release/v2.23] Add ability to override OSM resources #13288

merged 3 commits into from
Apr 12, 2024

Conversation

embik
Copy link
Member

@embik embik commented Apr 12, 2024

What this PR does / why we need it:

Manual cherry-pick of #13285. Adds the ability to override OSM resources and settings.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

Add `spec.componentsOverride.operatingSystemManager` to allow overriding OSM settings and resources

Documentation:

NONE

@embik embik requested a review from xrstf April 12, 2024 09:29
@kubermatic-bot kubermatic-bot added this to the KKP 2.23 milestone Apr 12, 2024
@kubermatic-bot kubermatic-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2024
@xrstf
Copy link
Contributor

xrstf commented Apr 12, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 306d351dd89dc88842f4e67c55db51f0c06b29b1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@embik
Copy link
Member Author

embik commented Apr 12, 2024

/retest

flake?

@embik embik added the cherry-pick-approved Indicates a PR has been approved by release managers. label Apr 12, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 12, 2024
@kubermatic-bot kubermatic-bot merged commit 5150099 into kubermatic:release/v2.23 Apr 12, 2024
20 checks passed
@embik embik deleted the osm-override-release-v2.23 branch April 12, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@embik @xrstf @kubermatic-bot