Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v2.25] Applications: discover if a release is stuck and rollback if necessary #13310

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #13301

/assign embik

Addressing inconsistencies in helm that lead to an Application stuck in "pending-install"

Signed-off-by: Simon Bein <simontheleg@gmail.com>
Signed-off-by: Simon Bein <simontheleg@gmail.com>
Signed-off-by: Simon Bein <simontheleg@gmail.com>
Signed-off-by: Simon Bein <simontheleg@gmail.com>
Signed-off-by: Simon Bein <simontheleg@gmail.com>
…rally via the logger

Signed-off-by: Simon Bein <simontheleg@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 17, 2024
@kubermatic-bot kubermatic-bot added this to the KKP 2.25 milestone Apr 17, 2024
@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Apr 17, 2024
@kubermatic-bot
Copy link
Contributor Author

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: cc @kubermatic/sig-release-managers.

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubermatic GitHub organization or not.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wurbanski for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2024
@embik
Copy link
Member

embik commented Apr 17, 2024

/cc @SimonTheLeg

@xrstf
Copy link
Contributor

xrstf commented Apr 22, 2024

/retest

@kubermatic-bot
Copy link
Contributor Author

@kubermatic-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-kubermatic-etcd-launcher-e2e 91a6747 link true /test pre-kubermatic-etcd-launcher-e2e
pre-kubermatic-expose-strategy-e2e 91a6747 link true /test pre-kubermatic-expose-strategy-e2e
pre-kubermatic-mla-e2e 91a6747 link true /test pre-kubermatic-mla-e2e
pre-kubermatic-opa-e2e 91a6747 link true /test pre-kubermatic-opa-e2e
pre-kubermatic-dualstack-e2e-aws-canal 91a6747 link true /test pre-kubermatic-dualstack-e2e-aws-canal
pre-kubermatic-dualstack-e2e-aws-cilium 91a6747 link true /test pre-kubermatic-dualstack-e2e-aws-cilium
pre-kubermatic-e2e-aws-ubuntu-1.28 91a6747 link true /test pre-kubermatic-e2e-aws-ubuntu-1.28
pre-kubermatic-e2e-aws-ubuntu-1.28-ce 91a6747 link true /test pre-kubermatic-e2e-aws-ubuntu-1.28-ce
pre-kubermatic-e2e-aws-ubuntu-1.27 91a6747 link true /test pre-kubermatic-e2e-aws-ubuntu-1.27
pre-kubermatic-e2e-aws-ubuntu-1.29 91a6747 link true /test pre-kubermatic-e2e-aws-ubuntu-1.29
pre-kubermatic-test-integration 91a6747 link true /test pre-kubermatic-test-integration
pre-kubermatic-test 91a6747 link true /test pre-kubermatic-test
pre-kubermatic-lint 91a6747 link true /test pre-kubermatic-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SimonTheLeg
Copy link
Member

SimonTheLeg commented Apr 23, 2024

I think this still fails because the functionality used only is available on newer helm version (which we have on the main branch). @embik should I just cherry pick the helm update onto this branch as well to make it work or what is the plan for this feature?

@embik
Copy link
Member

embik commented Apr 29, 2024

/close

in favour of #13332.

@kubermatic-bot
Copy link
Contributor Author

@embik: Closed this PR.

In response to this:

/close

in favour of #13332.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants