-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block vSphere on K8s 1.22 #7590
Block vSphere on K8s 1.22 #7590
Conversation
e6b4e12
to
f3635db
Compare
/retest |
2ec468a
to
663df82
Compare
b08b9fe
to
afd1cbf
Compare
/assign @xmudrii |
/retest |
/hold temporarily. I'm doing something on CI. Nothing to worry about. |
/hold cancel |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
1b65254
to
76b5bd7
Compare
@xmudrii LGTM lost after rebase (there was a conflict). Could you lgtm again please? |
LGTM label has been added. Git tree hash: 6f04bee4e7d608be01470bdef17b84d7c8f64c84
|
What this PR does / why we need it:
Since the necessity to block Kubernetes v1.22 on vSphere emerged under certain specific scenarios, this PR aims at implementing a generally available mechanism to block unwanted Kubernetes versions without the need to write custom code in the API server. The
extra-files
secret (whereversions.yaml
andupdates.yaml
reside) has been improved by introducing a new file:provider-incompatibilities.yaml
, whose structure is the following:Below are the parameters' details:
The conditions can be improved in the future, every field about the cluster or the datacenter is allowed (it's just a matter of a couple of lines of code).
Adding and removing constraints is very simple by using this mechanism: when in the future we'll allow using 1.22 clusters on vSphere, it will be enough to delete the above rules from the
defaults.go
file, without dealing with ad-hoc conditions embedded in the core code.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #7578
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?: