Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint for EKS resources #9002

Merged
merged 9 commits into from Feb 28, 2022
Merged

Add endpoint for EKS resources #9002

merged 9 commits into from Feb 28, 2022

Conversation

imharshita
Copy link
Contributor

@imharshita imharshita commented Feb 14, 2022 •
edited

Signed-off-by: Harshita sharma harshita.sharma6174@gmail.com

What does this PR do / Why do we need it: Add endpoint for EKS resources

Does this PR close any issues?:
Fixes #9057

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

GET endpoint for AMI types, Capacity types, Subnets, VPCs and Instance Types

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2022
@imharshita imharshita changed the title add endpoint for EKS AMI Types Add endpoint for EKS resources Feb 14, 2022
@imharshita
add endpoint for EKS AMI Types
8b467f8 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@imharshita
add endpoint for EKS Capacity Types
b77543b 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2022
@imharshita imharshita changed the title Add endpoint for EKS resources WIP - Add endpoint for EKS resources Feb 16, 2022
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 16, 2022
@imharshita
add Endpoint for EKS NodePool Subnets
c041f7e 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2022
@imharshita
resolve merge conflict
daecb7e 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@imharshita
add endpoint for EKS NodePool VPCs
d5711a8 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@kubermatic-bot kubermatic-bot added the sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. label Feb 22, 2022
@imharshita imharshita changed the title WIP - Add endpoint for EKS resources Add endpoint for EKS resources Feb 22, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2022
@imharshita
add endpoint for EKS NodePool InstanceTypes
bb48983 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
zreigz
zreigz suggested changes Feb 23, 2022
View reviewed changes
pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
pkg/handler/v2/routes_v2.go Outdated Show resolved Hide resolved
pkg/handler/v2/routes_v2.go Show resolved Hide resolved
@imharshita
change amitypes and capacitytypes endpoints
0bb300a 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@zreigz
Copy link
Contributor

zreigz commented Feb 24, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d80ddf687d3569a645eb26ccc827ce1e50cc1698

@zreigz
Copy link
Contributor

zreigz commented Feb 24, 2022

/retest

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 24, 2022
@imharshita
Copy link
Contributor Author

/retest

1 similar comment
@imharshita
Copy link
Contributor Author

/retest

@imharshita imharshita changed the title Add endpoint for EKS resources WIP - Add endpoint for EKS resources Feb 27, 2022
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2022
@imharshita
resolve merge conflict
abc0583 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@imharshita imharshita changed the title WIP - Add endpoint for EKS resources Add endpoint for EKS resources Feb 27, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2022
@zreigz
Copy link
Contributor

zreigz commented Feb 28, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 65ebba0d5f1456feb0e28a790a338bb9467978ce

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imharshita, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 6c4c8f3 into kubermatic:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zreigz zreigz zreigz requested changes

Assignees

@zreigz zreigz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add endpoints to get EKS resources for nodepool creation
3 participants
@imharshita @zreigz @kubermatic-bot