New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added autodownsampling so that Grafana finds data on longer range #9297
Added autodownsampling so that Grafana finds data on longer range #9297
Conversation
…suggested on thanos issue tracker
Please backport to 2.18 aas this is needed for our customer. |
/cherry-pick release-2.18 |
@dharapvj: once the present PR merges, I will cherry-pick it on top of release-2.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/cherry-pick release-2.18
This is not how the release branch is named.
LGTM label has been added. Git tree hash: eadffeb8ac1e109b5ce1df71ae6c6d55ce9de119
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharapvj, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dharapvj: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release/v2.18 |
@dharapvj: new pull request created: #10044 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release/v2.19 |
@dharapvj: new pull request created: #10045 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release/v2.20 |
@dharapvj: new pull request created: #10046 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added autodownsampling so that Grafana finds data on longer range as suggested on thanos issue tracker #601
What does this PR do / Why do we need it:
Currently, our grafana does not read downsampled Thanos data. This happens due to in default mode, Thanos will respond only with raw data - which we keep only for short duration like 7days.
So effectively, we cannot make use of Thanos for long term analysis at all with current setting.
Does this PR close any issues?:
Special notes for your reviewer:
Similar change was also done in prometheus operator
Documentation:
Does this PR introduce a user-facing change?: