Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added autodownsampling so that Grafana finds data on longer range #9297

Merged

Conversation

dharapvj
Copy link
Contributor

Added autodownsampling so that Grafana finds data on longer range as suggested on thanos issue tracker #601

What does this PR do / Why do we need it:
Currently, our grafana does not read downsampled Thanos data. This happens due to in default mode, Thanos will respond only with raw data - which we keep only for short duration like 7days.

So effectively, we cannot make use of Thanos for long term analysis at all with current setting.

Does this PR close any issues?:

Special notes for your reviewer:
Similar change was also done in prometheus operator

Documentation:

Does this PR introduce a user-facing change?:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2022
@toschneck
Copy link
Member

Please backport to 2.18 aas this is needed for our customer.

@dharapvj
Copy link
Contributor Author

/cherry-pick release-2.18

@kubermatic-bot
Copy link
Contributor

@dharapvj: once the present PR merges, I will cherry-pick it on top of release-2.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharapvj dharapvj requested a review from xrstf March 17, 2022 12:25
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/cherry-pick release-2.18

This is not how the release branch is named.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eadffeb8ac1e109b5ce1df71ae6c6d55ce9de119

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharapvj, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@kubermatic-bot kubermatic-bot merged commit 9fbf049 into kubermatic:master Mar 17, 2022
@kubermatic-bot
Copy link
Contributor

@dharapvj: cannot checkout release-2.18: error checking out release-2.18: exit status 1. output: error: pathspec 'release-2.18' did not match any file(s) known to git

In response to this:

/cherry-pick release-2.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharapvj
Copy link
Contributor Author

/cherry-pick release/v2.18

@kubermatic-bot
Copy link
Contributor

@dharapvj: new pull request created: #10044

In response to this:

/cherry-pick release/v2.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharapvj
Copy link
Contributor Author

/cherry-pick release/v2.19

@kubermatic-bot
Copy link
Contributor

@dharapvj: new pull request created: #10045

In response to this:

/cherry-pick release/v2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharapvj
Copy link
Contributor Author

/cherry-pick release/v2.20

@kubermatic-bot
Copy link
Contributor

@dharapvj: new pull request created: #10046

In response to this:

/cherry-pick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants