Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 'default' Nutanix project as special case #9332

Merged
merged 1 commit into from Mar 15, 2022
Merged

Handle 'default' Nutanix project as special case #9332

merged 1 commit into from Mar 15, 2022

Conversation

embik
Copy link
Member

@embik embik commented Mar 15, 2022

What does this PR do / Why do we need it:

The "default" project is a special case in Nutanix, it's the same as not defining a project at all. Since it can be selected from the UI, selecting it returns an empty list of subnets. This PR handles that case by omitting project references in downstream calls when the "default" project is selected.

Does this PR close any issues?:
Fixes #9330

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Correctly handle the 'default' Nutanix project in API calls

Signed-off-by: Marvin Beckers marvin@kubermatic.com

@embik
handle 'default' Nutanix project as special case
a68c09c 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 15, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2022
@embik
Copy link
Member Author

embik commented Mar 15, 2022

/retest

@embik embik requested a review from mate4st March 15, 2022 10:06
@embik
Copy link
Member Author

embik commented Mar 15, 2022

/cherry-pick release/v2.20

@kubermatic-bot
Copy link
Contributor

@embik: once the present PR merges, I will cherry-pick it on top of release/v2.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@embik
Copy link
Member Author

embik commented Mar 15, 2022

/hold

Waiting for pre-kubermatic-api-e2e to be fixed.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57d8496c008b4a05c1f6c43034aebe8d59b0a344

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2022
@embik
Copy link
Member Author

embik commented Mar 15, 2022

/hold cancel
/retest

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2022
@embik
Copy link
Member Author

embik commented Mar 15, 2022

/retest

1 similar comment
@embik
Copy link
Member Author

embik commented Mar 15, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit 4432afa into kubermatic:master Mar 15, 2022
@kubermatic-bot kubermatic-bot mentioned this pull request Mar 15, 2022
Merged
@kubermatic-bot
Copy link
Contributor

@embik: new pull request created: #9336

In response to this:

/cherry-pick release/v2.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@embik embik deleted the default-project branch October 20, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratikDeoghare PratikDeoghare PratikDeoghare approved these changes

@mate4st mate4st Awaiting requested review from mate4st

Assignees

@PratikDeoghare PratikDeoghare

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nutanix implementation does not return subnets for "default" project
3 participants
@embik @kubermatic-bot @PratikDeoghare