Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Kubernetes 1.20 #9384

Merged
merged 3 commits into from Mar 24, 2022
Merged

Remove support for Kubernetes 1.20 #9384

merged 3 commits into from Mar 24, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Mar 21, 2022

What does this PR do / Why do we need it:
Kubernetes 1.20 has gone EOL on February 28th, 2022. Time to remove it. This PR removes support for it, but configures an update rule to allow auto-updating all clusters to 1.21. To not run into errors when reconciling old clusters, most of the reconciling code can still handle 1.20 (e.g. the kubernetes-dashboard, etcd, ...). -- Those code places can be removed in a follow up KKP release when we're sure no 1.20 cluster exists anymore.

Does this PR introduce a user-facing change?:

Remove support for Kubernetes 1.20.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 21, 2022
@xrstf xrstf changed the title remove support for Kubernetes 1.20 WIP - Remove support for Kubernetes 1.20 Mar 21, 2022
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/api Denotes a PR or issue as being assigned to SIG API. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2022
@xrstf xrstf force-pushed the remove-kubernetes-1.20-eol branch from fe0a678 to 26c94b1 Compare March 21, 2022 10:10
@xrstf xrstf changed the title WIP - Remove support for Kubernetes 1.20 Remove support for Kubernetes 1.20 Mar 21, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2022
@xrstf xrstf force-pushed the remove-kubernetes-1.20-eol branch from 26c94b1 to a9cb7e4 Compare March 21, 2022 11:32
@xmudrii
Copy link
Member

xmudrii commented Mar 21, 2022

@xrstf I think we should also consider changing the default Kubernetes version to v1.22.

@xrstf
Copy link
Contributor Author

xrstf commented Mar 21, 2022

@xmudrii I was thinking "always use the most recent supported version, minus 1", that's why i kep the default. No strong feelings either way. Convince me! 😁

@xrstf xrstf force-pushed the remove-kubernetes-1.20-eol branch 2 times, most recently from 3883bd4 to e7cbc41 Compare March 21, 2022 17:27
@xmudrii
Copy link
Member

xmudrii commented Mar 21, 2022

I was thinking "always use the most recent supported version, minus 1", that's why i kep the default. No strong feelings either way. Convince me! 😁

I've always understood that rule as the latest Kubernetes version, minus 1, not the latest supported in KKP (as long as n-1 is supported by KKP). Considering that 1.21 is entering the maintenance mode at the end of April, and reaching EOL at the end of June, I think we should start promoting/defaulting to 1.22.

@xrstf
Copy link
Contributor Author

xrstf commented Mar 21, 2022

While rebasing I already changed the default in this PR 😁

xmudrii
xmudrii reviewed Mar 22, 2022
View reviewed changes
pkg/util/kubectl/kubectl.go Outdated Show resolved Hide resolved
pkg/resources/apiserver/deployment.go Outdated Show resolved Hide resolved
pkg/resources/controllermanager/deployment.go Outdated Show resolved Hide resolved
@xrstf xrstf force-pushed the remove-kubernetes-1.20-eol branch from 419b05e to 8907a63 Compare March 23, 2022 19:48
@xrstf xrstf requested a review from floreks March 23, 2022 21:11
@floreks
Copy link
Contributor

floreks commented Mar 24, 2022

/approve

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
xmudrii
xmudrii approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 140b19ef9b5843e615871bd4c719cb3f2ef2da0f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, xmudrii, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 94067da into kubermatic:master Mar 24, 2022
@xrstf xrstf deleted the remove-kubernetes-1.20-eol branch March 24, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@floreks floreks Awaiting requested review from floreks

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrstf @xmudrii @floreks @kubermatic-bot