Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite installer to use cobra #9398

Merged
merged 1 commit into from Mar 24, 2022
Merged

rewrite installer to use cobra #9398

merged 1 commit into from Mar 24, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Mar 21, 2022 •
edited

What does this PR do / Why do we need it:
This convert the installer to use cobra. I kept it simple and did not add things like auto-completion, dedicated validation stuff etc.

Does this PR close any issues?:
Fixes #8995.

Does this PR introduce a user-facing change?:

The kubermatic-installer uses Cobra instead of urfave/cli, but the CLI flags are identical, so no changes to scripts or automation should be necessary.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2022
@xrstf xrstf changed the title rewrite installer to use cobra WIP - rewrite installer to use cobra Mar 21, 2022
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2022
@xrstf xrstf force-pushed the cobra-installer branch 2 times, most recently from b317a19 to 778194d Compare March 21, 2022 19:19
@xrstf xrstf changed the title WIP - rewrite installer to use cobra rewrite installer to use cobra Mar 22, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2022
@xrstf xrstf requested a review from xmudrii March 22, 2022 15:57
xmudrii
xmudrii reviewed Mar 24, 2022
View reviewed changes
cmd/kubermatic-installer/main.go Show resolved Hide resolved
cmd/kubermatic-installer/main.go Show resolved Hide resolved
cmd/kubermatic-installer/main.go Show resolved Hide resolved
xmudrii
xmudrii approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d9db98648f362f86574f614307e767a5a11a9de

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 05027ac into kubermatic:master Mar 24, 2022
@xrstf xrstf deleted the cobra-installer branch March 24, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate installer away from urfave/cli
3 participants
@xrstf @kubermatic-bot @xmudrii