Add dual-stack support for GCP firewall rules #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
kubermatic-bot
added
release-note-none
PratikDeoghare
approved these changes
Mar 22, 2022
|
LGTM label has been added. Git tree hash: b721366cac4691635c1457e4a79f362d8e8f542c
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imharshita, rastislavs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
pkprzekwas
pushed a commit
to pkprzekwas/kubermatic
that referenced
this pull request
Mar 25, 2022
* Add dual-stack support to KKP-managed GCP firewall rules Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com> * Split firewall rules by IP family Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
pkprzekwas
pushed a commit
to pkprzekwas/kubermatic
that referenced
this pull request
Mar 25, 2022
* Add dual-stack support to KKP-managed GCP firewall rules Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com> * Split firewall rules by IP family Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
pkprzekwas
pushed a commit
to pkprzekwas/kubermatic
that referenced
this pull request
Mar 29, 2022
* Add dual-stack support to KKP-managed GCP firewall rules Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com> * Split firewall rules by IP family Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
kubermatic-bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
* Add dual-stack support for GCP firewall rules (#9400) * Add dual-stack support to KKP-managed GCP firewall rules Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com> * Split firewall rules by IP family Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com> * Adding unit tests for metering report configuration API * Adressing review comments * Adressing review comments (vol2) Co-authored-by: Rastislav Szabo <rastislav@kubermatic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / Why do we need it:
Adds dual-stack support for GCP firewall rules managed by KKP.
Does this PR close any issues?:
Fixes #9383
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?: