Add API endpoints for Nutanix categories #9466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kubermatic-bot
added
sig/api
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
size/XL
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
size/XXL
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: c1fdf3bbf4454559702e04e4ec3d869e90916977
|
kubermatic-bot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / Why do we need it:
This PR adds the following KKP API endpoints:
/v2/providers/nutanix/{dc}/categoriesfor category keys/v2/projects/{project_id}/clusters/{cluster_id}/providers/nutanix/categoriesfor category keys via cluster credentials/v2/providers/nutanix/{dc}/categories/{category}/valuesfor category values/v2/projects/{project_id}/clusters/{cluster_id}/providers/nutanix/categories/{category}/valuesfor category values via cluster credentialsThey are needed so the dashboard can offer autocompletion for Nutanix categories when creating MachineDeployments. That is important because categories do not exactly work like tags (in other providers): Only pre-existing category keys (names) and values can be used. So the dashboard should only offer categories and respective values that exist already.
Does this PR close any issues?:
Fixes #8927
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?: