Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual Stack support for OpenStack #9532

Merged
merged 4 commits into from Apr 7, 2022
Merged

Dual Stack support for OpenStack #9532

merged 4 commits into from Apr 7, 2022

Conversation

rastislavs
Copy link
Contributor

@rastislavs rastislavs commented Apr 4, 2022 •
edited

What does this PR do / Why do we need it:
Adds dual-stack support for OpenStack provider.

Dual-stack on OpenStack can be deployed in 3 ways:

  • (preferred) by referencing an IPv6 subnet pool used to allocate IPv6 subnet, or using the default IPv6 subnet pool (if it exists),
  • by referencing an existing IPv6 subnet,
  • if no IPv6 subnet pool is used, and existing subnet is not specified either, an IPv6 subnet will be created with a pre-defined private CIDR.

Does this PR close any issues?:
Fixes #9451

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Add dual-stack support for OpenStack provider.

@rastislavs
Add dual-stack support for OpenStack
3862a3f 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@rastislavs
Sort imports
d788bef 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 4, 2022
@rastislavs
Fix spelling
852c9dc 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 5, 2022
@rastislavs rastislavs changed the title WIP - Dual Stack support for OpenStack Dual Stack support for OpenStack Apr 5, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2022
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b789b9ae8fbc168cfdea7a1ba632ea516e7b0e0b

vgramer
vgramer reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@vgramer vgramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor changes

pkg/provider/cloud/openstack/provider.go Outdated Show resolved Hide resolved
pkg/provider/cloud/openstack/provider.go Outdated Show resolved Hide resolved
@rastislavs @vgramer
Apply suggestions from code review
d5f8ecc 
Co-authored-by: Vincent Gramer <vgramer@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022
@vgramer
Copy link
Contributor

vgramer commented Apr 5, 2022

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19f5a589519ae72cd9a10e0d4cc552940e995f90

@rastislavs
Copy link
Contributor Author

/retest

1 similar comment
@rastislavs
Copy link
Contributor Author

/retest

@imharshita
Copy link
Contributor

imharshita commented Apr 7, 2022 •
edited

/approve

1 similar comment
@imharshita
Copy link
Contributor

/approve

@rastislavs rastislavs requested a review from zreigz April 7, 2022 11:25
@zreigz
Copy link
Contributor

zreigz commented Apr 7, 2022

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imharshita, rastislavs, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2022
@kubermatic-bot kubermatic-bot merged commit 4d8e304 into kubermatic:master Apr 7, 2022
@rastislavs rastislavs mentioned this pull request Apr 8, 2022
Merged
@rastislavs rastislavs mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgramer vgramer vgramer left review comments

@PratikDeoghare PratikDeoghare PratikDeoghare approved these changes

@imharshita imharshita Awaiting requested review from imharshita

@zreigz zreigz Awaiting requested review from zreigz

Assignees

@vgramer vgramer

@PratikDeoghare PratikDeoghare

@zreigz zreigz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dual-stack support for KKP-managed OpenStack configuration
6 participants
@rastislavs @kubermatic-bot @vgramer @imharshita @zreigz @PratikDeoghare