Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipFamily option to clusterNetwork API #9652

Merged
merged 6 commits into from Apr 25, 2022
Merged

Add ipFamily option to clusterNetwork API #9652

merged 6 commits into from Apr 25, 2022

Conversation

rastislavs
Copy link
Contributor

What does this PR do / Why do we need it:
Adds optional ipFamily option to the clusterNetwork API, so that dual-stack clusters can be created without specifying pods and services CIDRs (which can now be defaulted for dual-stack clusters as well).

Does this PR close any issues?:
Fixes #9616

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Add optional ipFamily option to the clusterNetwork API.

@rastislavs
Add IP family cluster option
cb787c9 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@rastislavs
Add unit tests
6acb06f 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@rastislavs
Default IP Family
1c3132e 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@rastislavs
Simplify mutation test
9b656cb 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@rastislavs
Use constants in mutation test
04f2a28 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@rastislavs
Add more comments
10caefc 
Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 20, 2022
@rastislavs
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2538d2356137aa37e2763cae70d08fd2550db6e7

@rastislavs rastislavs requested a review from lsviben April 21, 2022 11:06
@lsviben
Copy link
Contributor

lsviben commented Apr 22, 2022

/approve
/lgtm

@imharshita
Copy link
Contributor

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imharshita, lsviben, rastislavs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@rastislavs
Copy link
Contributor Author

/retest

1 similar comment
@rastislavs
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 7f6ed1c into kubermatic:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratikDeoghare PratikDeoghare PratikDeoghare approved these changes

@lsviben lsviben Awaiting requested review from lsviben

Assignees

@PratikDeoghare PratikDeoghare

@lsviben lsviben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dual-stack / address family option to KKP cluster API
6 participants
@rastislavs @kubermatic-bot @lsviben @imharshita @kubermatic-triage-bot @PratikDeoghare