Don't set '--kubelet-certificate-authority' for 'bring-your-own' user clusters #9674
Conversation
… clusters Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
release-note
|
/cherry-pick release/v2.20 |
|
@embik: once the present PR merges, I will cherry-pick it on top of release/v2.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release/v2.19 |
|
@embik: once the present PR merges, I will cherry-pick it on top of release/v2.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM label has been added. Git tree hash: 8505d9bda50d0c811d58d6fcf7870f03b7448117
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@embik: new pull request created: #9675 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@embik: new pull request created: #9676 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What does this PR do / Why do we need it:
As per #9673, the "kubeadm" provider is special because it does not automatically rotate kubelet server TLS certificates, and the
--kubelet-certificate-authorityflag is problematic in that case. Eventually, we should make sure that TLS rotation properly happens on those clusters as well, but this PR (temporarily?) disables the flag for "kubeadm" clusters and this PR will be cherry-picked into 2.20 and 2.19. #8091 will likely end up being the complete fix, and after that is implemented this PR can be reverted.Does this PR close any issues?:
Fixes #9673
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?: