Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting seeds #9838

Merged
merged 1 commit into from May 18, 2022
Merged

Fix deleting seeds #9838

merged 1 commit into from May 18, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented May 18, 2022 •
edited

What does this PR do / Why do we need it:
This fixes a problem during seed cleanup. In #7558 we made it so that the KubermaticConfiguration is also synced onto each seed cluster. But because the changed code ( https://github.com/kubermatic/kubermatic/pull/7558/files#diff-de0ded63a6c09d74715c1b4f850442460cb0bf652d4ec20adc5035f7204526f6R181-R183 ) overwrites err with something new, err == nil doesn't represent "seed exists", but "config exists" now. And this causes the actual deletion on the seed to never happen.

This problem should affect KKP 2.18+, judging from the PR that broke it.

Does this PR close any issues?:
Fixes #9542

Does this PR introduce a user-facing change?:

Fix Seeds being deleted on the master cluster not being cleaned up in the seed clusters themselves.

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 18, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 18, 2022
@mate4st mate4st self-requested a review May 18, 2022 11:13
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d4eed603692a7c799a440fb22fd85b216be1c46f

@mate4st
Copy link
Contributor

mate4st commented May 18, 2022

/lgtm

@kubermatic-bot kubermatic-bot merged commit c519296 into kubermatic:master May 18, 2022
@xrstf xrstf deleted the fix-deleting-seeds branch May 18, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mate4st mate4st mate4st approved these changes

Assignees

@mate4st mate4st

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seed can't be deleted
3 participants
@xrstf @kubermatic-bot @mate4st