Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoints for VMware Cloud Director #9982

Merged
merged 3 commits into from Jun 7, 2022
Merged

Add endpoints for VMware Cloud Director #9982

merged 3 commits into from Jun 7, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

What does this PR do / Why do we need it:
Introduces the following endpoints for VMware Cloud Director:

  • /v2/providers/vmwareclouddirector/{dc}/networks
  • /v2/providers/vmwareclouddirector/{dc}/catalogs
  • /v2/providers/vmwareclouddirector/{dc}/templates/{catalog_name}

Does this PR close any issues?:
Fixes #9939

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Add endpoints to KKP API to list networks, catalogs, and templates for VMware Cloud Director

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jun 6, 2022
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jun 6, 2022
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik changed the title WIP: Add endpoints for VMware Cloud Director Add endpoints for VMware Cloud Director Jun 6, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2022
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>

// in: header
// name: Username
Username string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, do we use uppercase variables in other request structs as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maciaszczykm
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5106cc4bf507f4613df94b591eca07c6a3fd7d6e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit 5e372d3 into kubermatic:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API endpoints to list catalog, templates, and OVDC networks for VMware Cloud Director
4 participants