update in kubervirt rawconfig #1143

sankalp-r · 2022-01-03T14:50:44Z

Signed-off-by: Sankalp Rangare sankalprangare786@gmail.com

What this PR does / why we need it:
This PR updates kubeVirt's rawConfig and creation of VM using presets.

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #1113 , kubermatic/kubermatic#9108, kubermatic/kubermatic#9095

Special notes for your reviewer:

Optional Release Note:

Changing the config values for KubeVirt. This is a breaking change for KubeVirt cloud provider.

sankalp-r · 2022-01-03T23:04:30Z

/retest

ahmedwaleedmalik · 2022-01-04T07:43:57Z

@sankalp-r IMO this changeset introduces breaking changes for the existing kubevirt machine-deployments. I think we need to consider that as well, wdyt?

sankalp-r · 2022-01-04T11:16:19Z

@sankalp-r IMO this changeset introduces breaking changes for the existing kubevirt machine-deployments. I think we need to consider that as well, wdyt?

@ahmedwaleedmalik Yes these changes introduces breaking changes.
The idea is to fix machine-controller first, and then consume/update machine-controller version in KKP.

sankalp-r · 2022-01-04T18:31:04Z

/retest

moadqassem · 2022-01-07T11:22:17Z

/retest

sankalp-r · 2022-01-10T11:01:52Z

/retest

moadqassem · 2022-01-18T15:59:21Z

@sankalp-r What is the status of this PR ?

sankalp-r · 2022-01-18T16:09:12Z

@sankalp-r What is the status of this PR ?

As the UI for this change is not ready yet, can't proceed ahead.

This change needs UI changes as well, mentioned by Marcin:
#1113 (comment)

pkg/cloudprovider/provider/kubevirt/provider.go

pkg/cloudprovider/provider/kubevirt/types/types.go

pkg/cloudprovider/provider/kubevirt/provider.go

hdurand0710 · 2022-02-18T11:39:44Z

pkg/cloudprovider/provider/kubevirt/provider.go

 			Labels: map[string]string{
-				"kubevirt.io/vm": machine.Name,
+				"kubevirt.io/vm": c.VirtualMachineName,


We are missing the labels coming from the Preset here (from line 372).

Preset labels are only required to be added in VirtualMachineInstanceTemplateSpec (line 414)

hdurand0710 · 2022-02-18T12:45:56Z

/lgtm

kubermatic-bot · 2022-02-18T12:46:00Z

LGTM label has been added.

Git tree hash: f613de30201f084e7594618fd57bebad56834b51

sankalp-r · 2022-02-18T14:43:40Z

/retest

Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>

hdurand0710 · 2022-03-08T06:55:04Z

/hold cancel

moadqassem · 2022-03-08T09:49:01Z

/hold this PR will be merged after the release of machine controller.

hdurand0710 · 2022-03-09T06:29:00Z

pkg/cloudprovider/provider/kubevirt/provider.go

+	DNSPolicy          corev1.DNSPolicy
+	CPUs               string
+	Memory             string
+	Namespace          string


As we will merge #1204 in the same release, we should now remove the Namespace.

I find it confusing to keep the Namespace here as it's not a configurable option any more..

pkg/cloudprovider/provider/kubevirt/provider.go

hdurand0710 · 2022-03-09T10:35:06Z

pkg/cloudprovider/provider/kubevirt/provider.go

+	DNSPolicy          corev1.DNSPolicy
+	CPUs               string
+	Memory             string
+	Namespace          string


I find it confusing to keep the Namespace here as it's not a configurable option any more..

Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>

pkg/cloudprovider/provider/kubevirt/types/cloudconfig.go

pkg/cloudprovider/provider/kubevirt/provider.go

 			Labels: map[string]string{
-				"kubevirt.io/vm": machine.Name,
+				"kubevirt.io/vm": c.VirtualMachineName,


Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>

hdurand0710 · 2022-03-10T12:37:59Z

pkg/cloudprovider/provider/kubevirt/types/types.go

+// PrimaryDisk
+type PrimaryDisk struct {
+	Disk
+	OsImage providerconfigtypes.ConfigVarString `json:"osImage,omitempty"`


Do we want to have here the same struct as in provider.go ?

hdurand0710 · 2022-03-11T07:03:36Z

/lgtm

kubermatic-bot · 2022-03-11T07:03:39Z

LGTM label has been added.

Git tree hash: a936d56e7463d42d73f9a35493c1556416553140

moadqassem · 2022-03-11T07:50:28Z

/hold cancel

sankalp-r · 2022-03-11T08:20:07Z

/retest

moadqassem

/approve
/lgtm

kubermatic-bot · 2022-03-14T16:45:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadqassem, sankalp-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [moadqassem]
~~pkg/cloudprovider/provider/OWNERS~~ [moadqassem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sankalp-r · 2022-03-14T17:59:38Z

/retest

* update in kubervirt rawconfig Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com> * rawConfig field renaming Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com> * update kubevirt provider Config Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com> * add namespace option in CloudConfig Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com> * create VM in dedicated ns Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com> * remove vmName from rawConfig Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>

sankalp-r marked this pull request as draft January 4, 2022 11:12

kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2022

sankalp-r marked this pull request as ready for review January 4, 2022 15:05

kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2022

kubermatic-bot added the sig/osm Denotes a PR or issue as being assigned to SIG OSM. label Jan 10, 2022

sankalp-r added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2022

sankalp-r marked this pull request as draft February 1, 2022 10:50

sankalp-r requested a review from hdurand0710 February 17, 2022 08:21

sankalp-r marked this pull request as ready for review February 17, 2022 08:28

kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2022

hdurand0710 reviewed Feb 17, 2022

View reviewed changes

pkg/cloudprovider/provider/kubevirt/provider.go Outdated Show resolved Hide resolved

pkg/cloudprovider/provider/kubevirt/types/types.go Outdated Show resolved Hide resolved

pkg/cloudprovider/provider/kubevirt/provider.go Outdated Show resolved Hide resolved

hdurand0710 reviewed Feb 18, 2022

View reviewed changes

pkg/cloudprovider/provider/kubevirt/provider.go Outdated Show resolved Hide resolved

hdurand0710 reviewed Feb 18, 2022

View reviewed changes

kubermatic-bot assigned hdurand0710 Feb 18, 2022

kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2022

add namespace option in CloudConfig

f6457f7

Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>

kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022

kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2022

hdurand0710 reviewed Mar 9, 2022

View reviewed changes

create VM in dedicated ns

785b282

Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>

hdurand0710 reviewed Mar 10, 2022

View reviewed changes

pkg/cloudprovider/provider/kubevirt/provider.go Show resolved Hide resolved

pkg/cloudprovider/provider/kubevirt/provider.go Outdated

Labels: map[string]string{

"kubevirt.io/vm": machine.Name,

"kubevirt.io/vm": c.VirtualMachineName,

This comment was marked as outdated.

Sign in to view

remove vmName from rawConfig

17d4aee

Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>

hdurand0710 reviewed Mar 10, 2022

View reviewed changes

kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022

kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2022

hdurand0710 mentioned this pull request Mar 11, 2022

Create VM in dedicated namespace #1204

Closed

moadqassem approved these changes Mar 14, 2022

View reviewed changes

kubermatic-bot assigned moadqassem Mar 14, 2022

kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022

kubermatic-bot merged commit 72f156a into kubermatic:master Mar 14, 2022

ahmedwaleedmalik mentioned this pull request Mar 28, 2022

Synchronize KubeVirt with machine-controller kubermatic/operating-system-manager#156

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update in kubervirt rawconfig #1143

update in kubervirt rawconfig #1143

sankalp-r commented Jan 3, 2022 •

edited

sankalp-r commented Jan 3, 2022

ahmedwaleedmalik commented Jan 4, 2022 •

edited

sankalp-r commented Jan 4, 2022

sankalp-r commented Jan 4, 2022

moadqassem commented Jan 7, 2022

sankalp-r commented Jan 10, 2022

moadqassem commented Jan 18, 2022

sankalp-r commented Jan 18, 2022

hdurand0710 Feb 18, 2022

sankalp-r Feb 18, 2022

hdurand0710 Feb 18, 2022

This comment was marked as outdated.

hdurand0710 commented Feb 18, 2022

kubermatic-bot commented Feb 18, 2022

sankalp-r commented Feb 18, 2022

hdurand0710 commented Mar 8, 2022

moadqassem commented Mar 8, 2022

hdurand0710 Mar 9, 2022

hdurand0710 Mar 9, 2022

hdurand0710 Mar 9, 2022

This comment was marked as outdated.

hdurand0710 Mar 10, 2022

hdurand0710 commented Mar 11, 2022

kubermatic-bot commented Mar 11, 2022

moadqassem commented Mar 11, 2022

sankalp-r commented Mar 11, 2022

moadqassem left a comment

kubermatic-bot commented Mar 14, 2022

sankalp-r commented Mar 14, 2022

update in kubervirt rawconfig #1143

update in kubervirt rawconfig #1143

Conversation

sankalp-r commented Jan 3, 2022 • edited

sankalp-r commented Jan 3, 2022

ahmedwaleedmalik commented Jan 4, 2022 • edited

sankalp-r commented Jan 4, 2022

sankalp-r commented Jan 4, 2022

moadqassem commented Jan 7, 2022

sankalp-r commented Jan 10, 2022

moadqassem commented Jan 18, 2022

sankalp-r commented Jan 18, 2022

hdurand0710 Feb 18, 2022

Choose a reason for hiding this comment

sankalp-r Feb 18, 2022

Choose a reason for hiding this comment

hdurand0710 Feb 18, 2022

Choose a reason for hiding this comment

This comment was marked as outdated.

hdurand0710 commented Feb 18, 2022

kubermatic-bot commented Feb 18, 2022

sankalp-r commented Feb 18, 2022

hdurand0710 commented Mar 8, 2022

moadqassem commented Mar 8, 2022

hdurand0710 Mar 9, 2022

Choose a reason for hiding this comment

hdurand0710 Mar 9, 2022

Choose a reason for hiding this comment

hdurand0710 Mar 9, 2022

Choose a reason for hiding this comment

This comment was marked as outdated.

hdurand0710 Mar 10, 2022

Choose a reason for hiding this comment

hdurand0710 commented Mar 11, 2022

kubermatic-bot commented Mar 11, 2022

moadqassem commented Mar 11, 2022

sankalp-r commented Mar 11, 2022

moadqassem left a comment

Choose a reason for hiding this comment

kubermatic-bot commented Mar 14, 2022

sankalp-r commented Mar 14, 2022

sankalp-r commented Jan 3, 2022 •

edited

ahmedwaleedmalik commented Jan 4, 2022 •

edited