Differentiate CloudProviderName and KubeletCloudProviderName in templates #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
the
release-note
kubermatic-bot
added
dco-signoff: yes
embik
reviewed
Jan 13, 2022
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
xmudrii
force-pushed
the
fix-cloudprovidername
branch
from
1a94433
to
9c73e2f
Compare
embik
approved these changes
Jan 13, 2022
|
LGTM label has been added. Git tree hash: 4029c74b3db9314824d1a7afc90249585af5a613
|
ahmedwaleedmalik
approved these changes
Jan 13, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We currently use the
CloudProviderNamefield in templates for:--cloud-providerflag in the Kubelet serviceHowever,
CloudProviderNamecontains the value returned byGetCloudConfigfunction. This function returns the cloud provider name used by Kubelet, and only if the provider has an in-tree cloud provider implementation (in-tree CCM). In other words,CloudProviderNamewill be empty on providers such as Nutanix, DigitalOcean, Hetzner, etc...We encountered the issue when we tried to install some packages only on Nutanix machines in #1161. Because Nutanix doesn't have in-tree CCM,
.CloudProviderNameis empty, and the Nutanix-specific logic is not executed. Therefore, this PR is a prerequisite for #1161.This issue is fixed by differentiating
CloudProviderNameandKubeletCloudProviderName:CloudProviderNameisproviderConfig.CloudProvider. It's used in templates when we want to run cloud-provider-specific logic (e.g. install some packages only for one provider)KubeletCloudProviderNameis fromGetCloudConfig). It's passed to Kubelet via--cloud-provider` flagOptional Release Note:
/assign @embik @moadqassem @ahmedwaleedmalik