Make anexia provider more resilient against errors #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
dco-signoff: yes
|
Hi @kstiehl. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubermatic-bot
added
size/XL
|
@kstiehl Thank you very much for your effort. Can you please rebase your changes so we can start the reviewing process? Cheers! |
|
@moadqassem just randomly saw your request and will do that on @kstiehl's behalf, as he does not work for us anymore - commits will say unverified here on github though |
github-actions
bot
force-pushed
the
for-upstream/fix/make-machine-controller-more-resilient
branch
from
6b52096
to
5a4d0de
Compare
|
/retest |
|
@kstiehl can you please refactor the PR to take care of:
Other failures are not related to your PR and I'm taking a look at them. |
|
@ahmedwaleedmalik I'll look into it |
github-actions
bot
force-pushed
the
for-upstream/fix/make-machine-controller-more-resilient
branch
2 times, most recently
from
63c94c2
to
eb7ff85
Compare
kubermatic-bot
added
dco-signoff: no
github-actions
bot
force-pushed
the
for-upstream/fix/make-machine-controller-more-resilient
branch
from
eb7ff85
to
7ba9678
Compare
kubermatic-bot
added
dco-signoff: yes
github-actions
bot
force-pushed
the
for-upstream/fix/make-machine-controller-more-resilient
branch
from
7ba9678
to
3bdcbd8
Compare
Original commit by @kstiehl, conflicts resolved by @LittleFox94, mainly in pkg/cloudprovider/provider/anexia/provider.go Signed-off-by: kstiehl <kevin.stiehl@numericas.de> Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
github-actions
bot
force-pushed
the
for-upstream/fix/make-machine-controller-more-resilient
branch
from
3bdcbd8
to
c849820
Compare
|
/ok-to-test |
kubermatic-bot
added
the
ok-to-test
kubermatic-bot
removed
the
needs-ok-to-test
|
LGTM label has been added. Git tree hash: 1ff205f7475055b3b4c75308052364384da1a9db
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, kstiehl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
LittleFox94
deleted the
for-upstream/fix/make-machine-controller-more-resilient
branch
LittleFox94
added a commit
to anexia-it/machine-controller
that referenced
this pull request
Aug 15, 2022
* add conditions & tests Original commit by @kstiehl, conflicts resolved by @LittleFox94, mainly in pkg/cloudprovider/provider/anexia/provider.go Signed-off-by: kstiehl <kevin.stiehl@numericas.de> Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Fix various linter errors Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Add missing boilerplate to files Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Anexia provider: add dummy updater for tests Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> Co-authored-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
kubermatic-bot
pushed a commit
that referenced
this pull request
Aug 23, 2022
* Make anexia provider more resilient against errors (#1175) * add conditions & tests Original commit by @kstiehl, conflicts resolved by @LittleFox94, mainly in pkg/cloudprovider/provider/anexia/provider.go Signed-off-by: kstiehl <kevin.stiehl@numericas.de> Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Fix various linter errors Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Add missing boilerplate to files Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Anexia provider: add dummy updater for tests Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> Co-authored-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * docs(anexia): add info for templates (#1288) * docs(anexia): add info for templates Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Update anexia.md Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * anexia: increase HTTP client timeout to 120s (#1331) Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Anexia: extend disk configuration (#1402) * Anexia: cleanup Config/RawConfig attribute duplication types.Config and types.RawConfig contained the same members, with RawConfig using ConfigVars and Config storing the resolved data. This commit does some cleanup to ease adding new config values in the future. Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Anexia: extend disk configuration Adds a new config value "Disks", with each entry configuring the size and performance type of a single disk. The config format can be used for configuring multiple disks in the future, which is on our roadmap, but right now only a single disk is supported - with the added feature of defining the performance type. Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Anexia: update MachineDeployment example Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * CI: disable OperationSystemManager for Anexia Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> * Anexia: return reserved IP when instance IPs are requested When creating a machine at, we always first reserve an IP address for it. Later when retrieving the addresses of that machine, we rely on the vminfo API, which has some delay as it retrieves the IPs from the running VM. This commit adds the reserved address to the list of addresses returned from an instance, which should reduce provisioning time a bit and make it more stable. Also fixes a long-standing TODO comment: marking internal IPs as internal. Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com> Co-authored-by: Kevin Stiehl <kevinstiehl@live.de> Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kstiehl kevin.stiehl@numericas.de
What this PR does / why we need it:
The Anexia API can behave a little bit weird sometimes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Optional Release Note: