Update Azure SDK and API version #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
release-note
|
/retest |
|
LGTM label has been added. Git tree hash: 491c16c11a355fcbe93d4a9f912ed06583e11d79
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/retest Review the full test history Silence the bot with an |
embik
added a commit
to kubermatic-bot/machine-controller
that referenced
this pull request
May 20, 2022
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added a commit
that referenced
this pull request
May 23, 2022
#1299) * Add support for setting disk types (OS and data) Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Use correct disk types to compare against Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Rename diskType fields to diskSKU (Azure nomenclature) Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Check if SKU supports premium storage Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Cache SKU information Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Include Azure disk SKUs in e2e testing Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Implement disk SKU validation for ultra disks as well Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * CyClOmAtIc CoMpLeXitY Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Update pkg/cloudprovider/provider/azure/create_delete_resources.go Co-authored-by: Moath Qasim <moad.qassem@gmail.com> * Use map instead of slice to store allowed SKUs Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Remove label and adjust loop condition Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Update Azure SDK and API version (#1201) Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Co-authored-by: Marvin Beckers <10295525+embik@users.noreply.github.com> Co-authored-by: Moath Qasim <moad.qassem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our Azure dependencies could use an update, this bumps both the Azure SDK go module and the used Azure APIs. That unlocks some functionality the old APIs were lacking (for example, filtering SKUs by location). KKP already uses more recent API versions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Optional Release Note:
Signed-off-by: Marvin Beckers marvin@kubermatic.com