Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase number of inotify instances per user #1214

Merged
merged 1 commit into from
Mar 18, 2022
Merged

increase number of inotify instances per user #1214

merged 1 commit into from
Mar 18, 2022

Conversation

LittleFox94
Copy link
Contributor

What this PR does / why we need it:

We often run into the problem of not being able to kubectl logs -f because of all allowed inotify instances being in use. This increases the instance limit (from a default of 128 we saw) to 8192, giving some more breathing space.

Corresponds to #471, but increases the maximum number of instances instead of watches, as was recommended in kubernetes/kubernetes#10421 roughly a month after #471 was merged.

Special notes for your reviewer:

Instance limit of 8192 works great for us, but I have no calculation for how to choose this value.

Optional Release Note:

Increase the inotify instance limit to 8192

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Mar 16, 2022
@kubermatic-bot
Copy link
Contributor

Hi @LittleFox94. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2022
@github-actions github-actions bot force-pushed the for-upstream/feature/inotify-limits branch from f4b819d to 17d5506 Compare March 16, 2022 12:34
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Mar 16, 2022
@kron4eg
Copy link
Member

kron4eg commented Mar 16, 2022

@LittleFox94 please run go test ./pkg/userdata/... -update and commit the results.

@LittleFox94
Copy link
Contributor Author

@LittleFox94 please run go test ./pkg/userdata/... -update and commit the results.

which do you like better: in a new commit or squashed into the original one?

@kron4eg
Copy link
Member

kron4eg commented Mar 16, 2022

@LittleFox94 doesn't matter, in the end all commits will be squashed by the @kubermatic-bot (which is pushing merges).

@LittleFox94 @anx-release
increase number of inotify instances per user
aab8ca2 
This defaulted to 128, meaning a given user ID can have a maximum of
128 inotify instances. Increasing to 8192.

Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
@github-actions github-actions bot force-pushed the for-upstream/feature/inotify-limits branch from 17d5506 to aab8ca2 Compare March 16, 2022 12:43
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2022
@kron4eg
Copy link
Member

kron4eg commented Mar 16, 2022

/test all

@LittleFox94
Copy link
Contributor Author

I only see timeouts in the failed tests, is there anything I have to do @kron4eg ?

@kron4eg
Copy link
Member

kron4eg commented Mar 16, 2022

/retest

@kubermatic-bot
Copy link
Contributor

@LittleFox94: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member

kron4eg commented Mar 16, 2022

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a970b7a98d8f9b50cb24a125502e4f23e5dcc82d

@ahmedwaleedmalik
Copy link
Member

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg, LittleFox94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@kubermatic-bot kubermatic-bot merged commit 3d0a093 into kubermatic:master Mar 18, 2022
@LittleFox94 LittleFox94 mentioned this pull request Mar 18, 2022
Closed
@LittleFox94 LittleFox94 deleted the for-upstream/feature/inotify-limits branch March 18, 2022 13:34
@embik embik mentioned this pull request Nov 17, 2022
Merged
@LittleFox94
Copy link
Contributor Author

just randomly saw this is mentioned in the v1.46 release as being for our provider only - if anyone stumbles over this, this is, in fact, a provider-independent change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LittleFox94 @kubermatic-bot @kron4eg @ahmedwaleedmalik