Flatcar stop disabled units

[HaveFun83]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #

When FlatcarConfig.DisableUpdateEngine is set to true the update-engine.service is not stopped on new provisioned machines, which lead to an unwanted auto-updates to the latest flatcar version with a followed reboot.
Only after this first reboot the service is then disabled.
The stop command stop the systemd service instantly to suppress the first auto-update on new provisioned machines.

Special notes for your reviewer:

Optional Release Note:

fix disable auto-update when FlatcarConfig.DisableUpdateEngine is set to true

[kubermatic-bot]

Hi @HaveFun83. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kron4eg]

/assign @ahmedwaleedmalik

[ahmedwaleedmalik]

/ok-to-test

[HaveFun83]

@ahmedwaleedmalik @moadqassem is there a documented way to edit the flatcar/testdata/ignition* files? The stop command is missing here. I can edit but then the files are json beautified.

[moadqassem]

@ahmedwaleedmalik @moadqassem is there a documented way to edit the flatcar/testdata/ignition* files? The stop command is missing here. I can edit but then the files are json beautified.

@HaveFun83 Unfortunately not, but what you can do is, go to the ignition test and add the field DisableUpdateEngine here https://github.com/kubermatic/machine-controller/blob/master/pkg/userdata/flatcar/provider_test.go#L150. However, I am looking at the tests that are failing and I have the impression that, the tests are failing because of this newly introduced field. Are you sure that the field command is a valid ignition v1.20.1 field ?

[ahmedwaleedmalik]

@HaveFun83 this doesn't seem to be a valid field for the ignition config https://github.com/coreos/ignition/blob/spec2x/config/v2_2/types/schema.go#L221

[HaveFun83]

i removed the unsupported command: stop from the userDataIgnitionTemplate.

[ahmedwaleedmalik]

This PR only provides a partial solution i.e. it only fixes it for cloud-init and not ignition provisioning. We'll go ahead with this and then work on fixing this for ignition later.

[ahmedwaleedmalik]

/approve

[kubermatic-bot]

LGTM label has been added.

Git tree hash: 239ed9d987ca356a43532b5c5b4602a0dfa12a2c

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, HaveFun83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/userdata/OWNERS [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ahmedwaleedmalik]

/test pull-machine-controller-e2e-kubevirt

[kron4eg]

/cherrypick release/v1.43

[kubermatic-bot]

@kron4eg: new pull request created: #1264

In response to this:

/cherrypick release/v1.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.