Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable DHCPv6 on RHEL #1280

Merged
merged 4 commits into from
May 13, 2022
Merged

enable DHCPv6 on RHEL #1280

merged 4 commits into from
May 13, 2022

Conversation

PratikDeoghare
Copy link
Contributor

@PratikDeoghare PratikDeoghare commented May 10, 2022 •
edited

What this PR does / why we need it:

This enables DHCPv6 on RHEL machines.

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Part of kubermatic/kubermatic#9617

Optional Release Note:

NONE

@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2022
@PratikDeoghare PratikDeoghare changed the title configure IPv6 on RHEL machines enable DHCPv6 on RHEL May 12, 2022
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 12, 2022
@PratikDeoghare PratikDeoghare marked this pull request as ready for review May 12, 2022 10:45
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2022
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2022
@PratikDeoghare
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

@PratikDeoghare
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

@PratikDeoghare
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

1 similar comment
@PratikDeoghare
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

@PratikDeoghare
Copy link
Contributor Author

/test pull-machine-controller-e2e-azure

@PratikDeoghare
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

@PratikDeoghare
Copy link
Contributor Author

/test pull-machine-controller-e2e-azure

ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve ⚡

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ec85ca837ba334d292793ca4a8e020ba5f9bf2c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, PratikDeoghare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@ahmedwaleedmalik
Copy link
Member

/test pull-machine-controller-e2e-azure

@PratikDeoghare
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

@ahmedwaleedmalik
Copy link
Member

/test pull-machine-controller-e2e-kubevirt

@PratikDeoghare this won't work for now. Please don't re-run this. If your PR is urgent you can request @xrstf to override this CI job temporarily.

@PratikDeoghare
Copy link
Contributor Author

Oh I see. Thought it was just the flakes. Will ping him. Thanks!

@moadqassem
Copy link
Member

@PratikDeoghare I guess I know what is the issue, will fix it.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@PratikDeoghare
Copy link
Contributor Author

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@PratikDeoghare
Copy link
Contributor Author

/retest

1 similar comment
@PratikDeoghare
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit 2a55801 into kubermatic:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@moadqassem moadqassem Awaiting requested review from moadqassem

@rastislavs rastislavs Awaiting requested review from rastislavs

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PratikDeoghare @kubermatic-bot @ahmedwaleedmalik @moadqassem @kubermatic-triage-bot