Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubevirt switch to instancetype #1454

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Kubevirt switch to instancetype #1454

merged 3 commits into from
Oct 6, 2022

Conversation

hdurand0710
Copy link
Contributor

@hdurand0710 hdurand0710 commented Oct 3, 2022 •
edited
Loading

Signed-off-by: Helene Durand helene@kubermatic.com

What this PR does / why we need it:
KubeVirt support of instancetype and preferences and deprecation of flavor.
It also includes adding some unit tests.
The deprecation of flavor will happen in 2 steps:

  1. this PR: flavor and instancetype are still in use, no field is deprecated yet
  2. integration and use of instancetype in KKP
  3. dashboard update
  4. new machine-controller and KKP with deprecation of flavor

This will allow to keep dev working (including dashboard) until the migration is over.

Which issue(s) this PR fixes:

Fixes #1452

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

KubeVirt: support of instancetype and preferences (deprecation of flavor).

Documentation:

TBD (will be done when last PR is merged in the Epic and UI is designed).

@hdurand0710 hdurand0710 added the sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. label Oct 3, 2022
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/provided Denotes a PR that has a valid documentation reference. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 3, 2022
@hdurand0710
Copy link
Contributor Author

/retest

@mfranczy
Copy link
Contributor

mfranczy commented Oct 4, 2022

/assign @mfranczy

@hdurand0710 hdurand0710 self-assigned this Oct 4, 2022
@hdurand0710 hdurand0710 changed the title Kubevirt switch to instancetype [WIP] Kubevirt switch to instancetype Oct 5, 2022
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2022
Kubevirt switch to instancetype
c2d8aaa 
Signed-off-by: Helene Durand <helene@kubermatic.com>
@hdurand0710 hdurand0710 changed the title [WIP] Kubevirt switch to instancetype Kubevirt switch to instancetype Oct 5, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2022
@hdurand0710
Copy link
Contributor Author

/retest

Fix example file
0582b89 
Signed-off-by: Helene Durand <helene@kubermatic.com>
@hdurand0710
Copy link
Contributor Author

/retest

1 similar comment
@hdurand0710
Copy link
Contributor Author

/retest

Code review comment
7c169f1 
Signed-off-by: Helene Durand <helene@kubermatic.com>
@sankalp-r
Copy link
Contributor

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87aecf97d26443d9348d701123b7555280457e2c

@hdurand0710
Copy link
Contributor Author

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve ⚡

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, hdurand0710, sankalp-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@kubermatic-bot kubermatic-bot merged commit 2ccc22a into kubermatic:master Oct 6, 2022
mfranczy
mfranczy reviewed Oct 6, 2022
View reviewed changes
examples/kubevirt-machinedeployment.yaml
kind: "VirtualMachineInstancetype" # Allowed values: "VirtualMachineInstancetype"/"VirtualMachineClusterInstancetype"
preference:
name: "sockets-advantage"
category: "VirtualMachinePreference" # Allowed values: "VirtualMachinePreference"/"VirtualMachineClusterPreference"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to change to kind :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks, done in the same next PR as the switch to 1.55.0.

go.mod
@@ -56,7 +56,7 @@ require (
k8s.io/kubelet v0.24.2
k8s.io/utils v0.0.0-20220728103510-ee6ede2d64ed
kubevirt.io/api v0.57.1
kubevirt.io/containerized-data-importer-api v1.50.0
kubevirt.io/containerized-data-importer-api v1.54.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we switch to v1.55.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1456

@hdurand0710 hdurand0710 deleted the 1452-instancetypes branch October 7, 2022 06:15
mate4st pushed a commit to mate4st/machine-controller that referenced this pull request Mar 13, 2023
@hdurand0710 @mate4st
Kubevirt switch to instancetype (kubermatic#1454)
8d04fd3 
* Kubevirt switch to instancetype

Signed-off-by: Helene Durand <helene@kubermatic.com>

* Fix example file

Signed-off-by: Helene Durand <helene@kubermatic.com>

* Code review comment

Signed-off-by: Helene Durand <helene@kubermatic.com>

Signed-off-by: Helene Durand <helene@kubermatic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sankalp-r sankalp-r sankalp-r left review comments

@mfranczy mfranczy mfranczy left review comments

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@sankalp-r sankalp-r

@ahmedwaleedmalik ahmedwaleedmalik

@mfranczy mfranczy

@hdurand0710 hdurand0710

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KubeVirt switch to instancetype
5 participants
@hdurand0710 @mfranczy @sankalp-r @kubermatic-bot @ahmedwaleedmalik