Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set EvictionStrategy to external on KubeVirt VMs #1504

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Set EvictionStrategy to external on KubeVirt VMs #1504

merged 4 commits into from
Dec 2, 2022

Conversation

dermorz
Copy link
Contributor

@dermorz dermorz commented Dec 2, 2022

What this PR does / why we need it:
This change will block automatic VMs eviction which will then need to be handled externally. kubermatic/kubermatic#11562

What type of PR is this?

Does this PR introduce a user-facing change? Then add your Release Note here:

KubeVirt: Set eviction strategy of VMIs to external

Documentation:

NONE

@dermorz
Set EvictionStrategy to external on kubevirt VMI
3cb76bf 
Signed-off-by: Moritz Bracht <mail@morz.me>
@dermorz
Add remark about EvictionStratey in kubevirt docs
454afb0 
Signed-off-by: Moritz Bracht <mail@morz.me>
@dermorz
Adjust testdata
7e500e2 
Signed-off-by: Moritz Bracht <mail@morz.me>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2022
@hdurand0710
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
mfranczy
mfranczy suggested changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small comment

docs/kubevirt.md Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
@dermorz
Improve kubevirt eviction strategy docs
b18e032 
Signed-off-by: Moritz Bracht <mail@morz.me>
mfranczy
mfranczy approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8038c9d5b656c64b94336a7fc27978a940f21571

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dermorz, mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@dermorz
Copy link
Contributor Author

dermorz commented Dec 2, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit e611f09 into kubermatic:main Dec 2, 2022
@dermorz dermorz mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranczy mfranczy mfranczy approved these changes

@hdurand0710 hdurand0710 Awaiting requested review from hdurand0710

Assignees

@mfranczy mfranczy

@hdurand0710 hdurand0710

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dermorz @hdurand0710 @kubermatic-bot @mfranczy