Allow specifying full image reference for GCP #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
release-note
kubermatic-bot
added
the
size/XS
|
/approve |
|
LGTM label has been added. Git tree hash: d66c23800078247c378c768e3111a1d56fa8c85c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, kron4eg, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have an issue when creating ARM64-based instances on GCP:
It appears that the image we use is only compatible with AMD64-based instances. We would have to use another image with ARM64-based instances, which appears to be
projects/ubuntu-os-cloud/global/images/family/ubuntu-2204-lts-arm64.We could do that by using the custom image option, but the current implementation assumes that the custom image is in the user's project. That's not the case because this image is in the global
ubuntu-os-cloudproject.This PR ensures that we can specify custom images in other projects while making sure we don't break backwards compatibility.
What type of PR is this?
/kind feature
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: