Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate datastore cluster for vSphere to cloud-config #1682

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Propagate datastore cluster for vSphere to cloud-config #1682

merged 1 commit into from
Jul 18, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
In case user has specified DatastoreCluster for a machine deployment on vSphere, we should use that as the datastore in cloud-config so that the disks attached to the VM are placed accordingly.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

vSphere: Fix a bug where datastore cluster value was not being propagated to the cloud-config

Documentation:

NONE

@ahmedwaleedmalik
Propagate datastore cluster for vSphere to cloud-config
b35184b 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 14, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jul 14, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2023
@ahmedwaleedmalik
Copy link
Member Author

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2023
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-vsphere-datastore-cluster

@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-vsphere

@ahmedwaleedmalik
Copy link
Member Author

pull-machine-controller-e2e-vsphere-datastore-cluster

Fails because dsc-1 datacenter doesn't exist.

@mate4st
Copy link
Contributor

mate4st commented Jul 17, 2023

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 550675ce6ea62fcbf0c7c4c95d9b48b8017587fb

@ahmedwaleedmalik
Copy link
Member Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@ahmedwaleedmalik
Copy link
Member Author

pull-machine-controller-e2e-vsphere-datastore-cluster

Fails because dsc-1 datacenter doesn't exist.

@xrstf can you please override this.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahmedwaleedmalik
Copy link
Member Author

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@xrstf
Copy link
Contributor

xrstf commented Jul 18, 2023

/override pull-machine-controller-e2e-vsphere-datastore-cluster

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vsphere-datastore-cluster

In response to this:

/override pull-machine-controller-e2e-vsphere-datastore-cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@kubermatic-bot kubermatic-bot merged commit e5f238c into kubermatic:main Jul 18, 2023
16 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the vsphere-datastore-cluster branch July 18, 2023 09:06
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v1.57

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #1695

In response to this:

/cherry-pick release/v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem Awaiting requested review from moadqassem

@mate4st mate4st Awaiting requested review from mate4st

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@mate4st mate4st

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmedwaleedmalik @kubermatic-bot @mate4st @kubermatic-triage-bot @xrstf