Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: fix rocky linux description filter #1733

Merged

Conversation

wozniakjan
Copy link
Contributor

@wozniakjan wozniakjan commented Nov 23, 2023

What this PR does / why we need it:
The e2e dualstack tests started to fail consistently
https://public-prow.loodse.com/job-history/gs/prow-dev-public-data/pr-logs/directory/pre-kubermatic-dualstack-e2e-aws-canal

2023-11-22T13:18:27.476Z	info	wait/wait.go:85	Waiting: 3 of 4 nodes are ready (unready: [])	{"provider": "aws", "cni": "canal", "ipfamily": "IPv4+IPv6", "cluster": "dualstack-e2e-7tr4m"}
2023-11-22T13:18:57.469Z	info	wait/wait.go:85	Waiting: failed to list nodes: client rate limiter Wait returned an error: context deadline exceeded	{"provider": "aws", "cni": "canal", "ipfamily": "IPv4+IPv6", "cluster": "dualstack-e2e-7tr4m"}
    cloud_providers_dualstack_test.go:455: Not all nodes did get ready: context deadline exceeded; last error was: failed to list nodes: client rate limiter Wait returned an error: context deadline exceeded
2023-11-22T13:18:57.518Z	info	jig/cluster.go:428	Deleting cluster...	{"provider": "aws", "cni": "canal", "ipfamily": "IPv4+IPv6", "cluster": "dualstack-e2e-7tr4m", "cluster": "dualstack-e2e-7tr4m"}
$ k describe machine -n kube-system md-rockylinux-c4d6455c5-rdhcv
...
  Type     Reason            Age                   From                Message
  ----     ------            ----                  ----                -------
  Warning  ReconcilingError  45s (x18 over 4m57s)  machine-controller  An error of type = InvalidConfiguration, with message = Failed to get AMI-ID for operating system rockylinux in region eu-west-1: could not find Image for 'rockylinux' with arch 'x86_64' occurred

The reason is the description for rocky linux images changed and includes prefix where are these images copied from: [Copied ami-077c5602b64cb2c66 from us-east-2] Rocky-8-ec2-8.6-20220515.0.x86_64

$ aws ec2 describe-images --region eu-central-1 --owners 792107900819 --filters "Name=description,Values=*Rocky-8-ec2-8*.x86_64"  --query 'Images[*].[ImageId,Name,Description,OwnerId,VirtualizationType,RootDeviceType,Architecture]' --output table
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|                                                                                     DescribeImages                                                                                      |
+-----------------------+------------------------------------+-----------------------------------------------------------------------------------+---------------+------+------+----------+
|  ami-053c6780c32bd5d5e|  Rocky-8-ec2-8.6-20220515.0.x86_64 |  [Copied ami-077c5602b64cb2c66 from us-east-2] Rocky-8-ec2-8.6-20220515.0.x86_64  |  792107900819 |  hvm |  ebs |  x86_64  |
+-----------------------+------------------------------------+-----------------------------------------------------------------------------------+---------------+------+------+----------+

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind chore

Special notes for your reviewer:
maybe for the next KKP release, we could set these filters on the Seed CRD like we do for the KubeVirt images?

Does this PR introduce a user-facing change? Then add your Release Note here:

aws: fix rocky linux description filter

Documentation:

NONE

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2023
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d003a07e1ed7769394d6019b436fea28ef133f79

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@embik
Copy link
Member

embik commented Nov 23, 2023

Should have a release note because it changes the filter.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 23, 2023
@wozniakjan
Copy link
Contributor Author

/cherry-pick release/v1.58
/cherry-pick release/v1.57
/cherry-pick release/v1.56

@kubermatic-bot
Copy link
Contributor

@wozniakjan: once the present PR merges, I will cherry-pick it on top of release/v1.58 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.58
/cherry-pick release/v1.57
/cherry-pick release/v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 953e653 into kubermatic:main Nov 23, 2023
15 of 16 checks passed
@kubermatic-bot
Copy link
Contributor

@wozniakjan: new pull request created: #1734

In response to this:

/cherry-pick release/v1.58
/cherry-pick release/v1.57
/cherry-pick release/v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@wozniakjan: new pull request created: #1735

In response to this:

/cherry-pick release/v1.58
/cherry-pick release/v1.57
/cherry-pick release/v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@wozniakjan: new pull request created: #1736

In response to this:

/cherry-pick release/v1.58
/cherry-pick release/v1.57
/cherry-pick release/v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wozniakjan added a commit to wozniakjan/kubermatic that referenced this pull request Nov 23, 2023
wozniakjan added a commit to wozniakjan/kubermatic that referenced this pull request Nov 23, 2023
wozniakjan added a commit to wozniakjan/kubermatic that referenced this pull request Nov 23, 2023
kubermatic-bot pushed a commit to kubermatic/kubermatic that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants