Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.56] Use JoinPath to construct vSphere url #1741

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[release/v1.56] Use JoinPath to construct vSphere url #1741

merged 1 commit into from
Dec 12, 2023

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1738

/assign embik

No longer fail constructing vSphere endpoint when a `/` suffix is present in the datacenter configuration

@embik
Use JoinPath to construct vSphere url
b472680 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kubermatic-bot kubermatic-bot mentioned this pull request Dec 6, 2023
Merged
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2023
@embik
Copy link
Member

embik commented Dec 8, 2023

/retest

@embik embik mentioned this pull request Dec 8, 2023
Merged
@embik
Copy link
Member

embik commented Dec 11, 2023

/retest

1 similar comment
@embik
Copy link
Member

embik commented Dec 11, 2023

/retest

embik
embik approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 254325d195bff1876395c52b2737f266d64e0f64

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@kubermatic-bot kubermatic-bot merged commit 91f9179 into kubermatic:release/v1.56 Dec 12, 2023
16 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1738-to-release/v1.56 branch December 12, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kubermatic-bot @embik