Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.56] Remove TORCX_BINDIR from containerd binary call #1763

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

embik
Copy link
Member

@embik embik commented Feb 16, 2024

What this PR does / why we need it:
Manual cherry-pick of #1760.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix containerd configuration for Flatcar nodes on stable 3815.2.0 or higher

Documentation:

NONE

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2024
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member

xmudrii commented Feb 21, 2024

/retest

@xmudrii
Copy link
Member

xmudrii commented Feb 21, 2024

/test pull-machine-controller-e2e-vmware-cloud-director

@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2024
@xrstf
Copy link
Contributor

xrstf commented Feb 21, 2024

/override pull-machine-controller-e2e-openstack

Doesn't support 1.26 somehow.

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-openstack

In response to this:

/override pull-machine-controller-e2e-openstack

Doesn't support 1.26 somehow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor

xrstf commented Feb 21, 2024

/override pull-machine-controller-e2e-vmware-cloud-director

flaking

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vmware-cloud-director

In response to this:

/override pull-machine-controller-e2e-vmware-cloud-director

flaking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor

xrstf commented Feb 21, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e365507757c8f7597305e1fd60bd855dae1bffeb

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@kubermatic-bot kubermatic-bot merged commit e4e0835 into kubermatic:release/v1.56 Feb 21, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants