Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for kubernetes 1.26 #1769

Merged
merged 3 commits into from Mar 6, 2024
Merged

Drop support for kubernetes 1.26 #1769

merged 3 commits into from Mar 6, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Mar 5, 2024 •
edited

What this PR does / why we need it:
1.26 has reached EOL https://kubernetes.io/releases/#release-v1-26

This PR also updates the k8s matrix for tests to the latest available versions and switches to GCE as the default tests.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove support for Kubernetes v1.26

Documentation:

https://github.com/kubermatic/docs/pull/1623

@ahmedwaleedmalik
Drop support for kubernetes 1.26
9f2d487 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Mar 5, 2024
@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2024
@ahmedwaleedmalik
Update matrix for e2e tests
7e6df9e 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/none Denotes a PR that doesn't need documentation (changes). labels Mar 5, 2024
@kron4eg
Copy link
Member

kron4eg commented Mar 5, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a1edcd4aa641ec7f9bb481d0de335fe6c807098f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@ahmedwaleedmalik
Copy link
Member Author

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahmedwaleedmalik
Copy link
Member Author

/hold to avoid retries
/test pull-machine-controller-e2e-gce-legacy-userdata

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@ahmedwaleedmalik
Built in cloud providers are disabled in k8s 1.26
412b58a 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@ahmedwaleedmalik
Copy link
Member Author

@xrstf vSphere seems borked; pull-machine-controller-e2e-vsphere will need an override.

@xrstf
Copy link
Contributor

xrstf commented Mar 6, 2024

/override pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member

kron4eg commented Mar 6, 2024

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@kron4eg
Copy link
Member

kron4eg commented Mar 6, 2024

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c15ebf1bb3b4648ac34121a4bb8424108aee184

@kubermatic-bot kubermatic-bot merged commit 4342ca2 into kubermatic:main Mar 6, 2024
22 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the drop-1.26 branch March 6, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmedwaleedmalik @kron4eg @kubermatic-bot @kubermatic-triage-bot @xrstf