Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.57] Fix vSphere anti-affinity #1783

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[release/v1.57] Fix vSphere anti-affinity #1783

merged 2 commits into from
Apr 26, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

This is a manual cherry-pick of #1779

vSphere: fix anti-affinity DRS configuration for VMs

/kind bug

@ahmedwaleedmalik
Fix vSphere anti-affinity (kubermatic#1779)
c0bca51 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 26, 2024
@ahmedwaleedmalik ahmedwaleedmalik force-pushed the release-v1.57/vsphere-anti-affinity branch from 41c7c37 to 988c441 Compare April 26, 2024 09:42
@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik
Fixes
50f2612 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik force-pushed the release-v1.57/vsphere-anti-affinity branch from 988c441 to 50f2612 Compare April 26, 2024 10:27
@ahmedwaleedmalik
Copy link
Member Author

@xrstf pull-machine-controller-e2e-vsphere will fail because of the rocky linux issue #1777 (comment)

xmudrii
xmudrii approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a049a1b9c3293cf04d752b31b000c3afdaacc1a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@xrstf
Copy link
Contributor

xrstf commented Apr 26, 2024

/override pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 7f39570 into kubermatic:release/v1.57 Apr 26, 2024
15 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the release-v1.57/vsphere-anti-affinity branch April 26, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf @xmudrii