Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Flatcar in Packet cloud provider #802

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Support Flatcar in Packet cloud provider #802

merged 1 commit into from
Aug 31, 2020

Conversation

dongsupark
Copy link
Contributor

@dongsupark dongsupark commented Jul 31, 2020 •
edited

To allow Flatcar to be used as one of the operating systems, we need to update getNameForOS() so it also accepts the input value flatcar in operatingSystem of the provider config.

Optional Release Note:

support Flatcar in Packet cloud provider

@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2020
@kubermatic-bot
Copy link
Contributor

Hi @dongsupark. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 31, 2020
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jul 31, 2020
xmudrii
xmudrii reviewed Jul 31, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongsupark Thank you for the PR! Would you mind chaging the Packet E2E test suite to enable testing Flatcar? Everything you need to do is to modify this line and drop flatcar from the slice.

Support Flatcar in Packet cloud provider
0e84100 
To allow Flatcar to be used as one of the operating systems, we need to
update `getNameForOS()` so it also accepts the input value `flatcar` in
`operatingSystem` of the provider config.

Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
@dongsupark
Copy link
Contributor Author

Done. Updated the Packet e2e test.
Thanks for the review.

xmudrii
xmudrii approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💯

/lgtm
/approve
/test all

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac44bbda5b544ab4df37de3b9c299bb550524147

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongsupark, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
@xmudrii
Copy link
Member

xmudrii commented Jul 31, 2020

/test pull-machine-controller-e2e-aws-ebs-encryption-enabled

@dongsupark
Copy link
Contributor Author

/retest

@kubermatic-bot
Copy link
Contributor

@dongsupark: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Jul 31, 2020

/hold
we are aware of the problem and we are working on fixing it

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020
@xmudrii xmudrii mentioned this pull request Aug 4, 2020
Closed
@xmudrii
Copy link
Member

xmudrii commented Aug 22, 2020

/test pull-machine-controller-e2e-packet

@xmudrii
Copy link
Member

xmudrii commented Aug 22, 2020

The instance type that we use for E2E tests is not available anymore. I'll try to find an alternative instance type next week.

@xmudrii
Copy link
Member

xmudrii commented Aug 31, 2020

/test pull-machine-controller-e2e-packet

@xmudrii
Copy link
Member

xmudrii commented Aug 31, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@kubermatic-bot kubermatic-bot merged commit aea6ef8 into kubermatic:master Aug 31, 2020
@dongsupark dongsupark deleted the dongsu/packet-flatcar branch August 31, 2020 15:13
@dongsupark
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dongsupark @kubermatic-bot @xmudrii @kubermatic-triage-bot