Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker to 19.03.12 for Ubuntu, CentOS, RHEL #815

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 1, 2020

What this PR does / why we need it:

This PR updates Docker to 19.03.12 for Ubuntu, CentOS, and RHEL clusters running Kubernetes 1.17 and newer. The clusters running Kubernetes 1.16 and older are using Docker 18.06, as before this change.

The reason for updating Docker is that there is an issue with collecting metrics on 1.19 clusters using Docker 18.06. More details can be found in the following Kubernetes issue: kubernetes/kubernetes#94281

Special notes for your reviewer:

  • I've decided to go with 19.03.12 as we already use it in KubeOne.
  • Flatcar is still using Docker 18.06, as there is no stable release that includes Docker 19.03. There is a beta release that comes with Docker 19.03.11. If users want to use Flatcar with Kubernetes 1.19, and utilize the metrics, they can specify the custom AMI for Flatcar Beta if they're confident using it.
  • I'm not sure which version is used by SLES. It seems like SLES comes with Docker, similar to Flatcar, as I don't see that we install it manually.

Optional Release Note:

Update Docker to 19.03.12 for Ubuntu, CentOS, and RHEL clusters running Kubernetes 1.17 and newer

/assign @kron4eg @xrstf

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2020
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2020
@kron4eg
Copy link
Member

kron4eg commented Sep 1, 2020

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a224a18317ca40c6022119676aece51a13c205fb

@kubermatic-bot kubermatic-bot merged commit b0d51a0 into kubermatic:master Sep 1, 2020
@xmudrii xmudrii deleted the docker-19.03 branch September 1, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants