Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mfranczy to repo owners #973

Merged
merged 1 commit into from May 20, 2021
Merged

Add mfranczy to repo owners #973

merged 1 commit into from May 20, 2021

Conversation

mfranczy
Copy link
Contributor

Signed-off-by: Marcin Franczyk marcin0franczyk@gmail.com

What this PR does / why we need it:
Add mfranczy to repo owners

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Optional Release Note:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2021
@mfranczy
Copy link
Contributor Author

/test pull-machine-controller-e2e-azure

@mfranczy mfranczy requested a review from moadqassem May 17, 2021 14:30
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 40dff216881baa2bada424399a128ac8f68c274f

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
moadqassem
moadqassem reviewed May 17, 2021
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@moadqassem
Copy link
Member

@mfranczy
I am trying to fix the current the issue with Azure. Will open a PR soon and then this PR can be merged

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@moadqassem
Copy link
Member

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2021
@moadqassem
Copy link
Member

/retes

@mfranczy
add mfranczy to repo owners
a8b9737 
Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
moadqassem
moadqassem reviewed May 20, 2021
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 84db36f010b4b4c16350e2f5d3c7882b04c61db0

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfranczy, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moadqassem
Copy link
Member

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
@kubermatic-bot kubermatic-bot merged commit 7442978 into kubermatic:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem moadqassem left review comments

Assignees

@moadqassem moadqassem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mfranczy @kubermatic-bot @moadqassem @kubermatic-triage-bot