Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the rhel ga instead of custom image on azure #975

Merged
merged 1 commit into from
May 19, 2021
Merged

use the rhel ga instead of custom image on azure #975

merged 1 commit into from
May 19, 2021

Conversation

moadqassem
Copy link
Member

What this PR does / why we need it:
Using RHEL GA images instead of custom images.

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #974

Special notes for your reviewer:

Optional Release Note:

None

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 18, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2021
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2021
@moadqassem moadqassem force-pushed the fix-rhel-on-azure branch 3 times, most recently from 414ee94 to 2527a59 Compare May 18, 2021 21:51
@moadqassem
Copy link
Member Author

/retest

@moadqassem
Copy link
Member Author

/test pull-machine-controller-e2e-azure

@moadqassem moadqassem force-pushed the fix-rhel-on-azure branch 2 times, most recently from 730959b to 6c33e0f Compare May 19, 2021 08:47
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2021
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented May 19, 2021 •
edited

@moadqassem: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-machine-controller-e2e-aws-arm 414ee94 link /test pull-machine-controller-e2e-aws-arm

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@moadqassem
Copy link
Member Author

/test pull-machine-controller-e2e-azure-custom-image-reference

@moadqassem
use the rhel ga instead of custom image on azure
808aa5a 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
kron4eg
kron4eg reviewed May 19, 2021
View reviewed changes
pkg/userdata/rhel/provider.go
@@ -204,7 +204,9 @@ write_files:
{{- /* https://bugs.launchpad.net/cloud-init/+bug/1662542 */}}
hostnamectl set-hostname {{ .MachineSpec.Name }}
{{ end }}

{{ if eq .CloudProviderName "azure" }}
yum update -y --disablerepo='*' --enablerepo='*microsoft*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this should be gated under {{- if .OSConfig.DistUpgradeOnBoot }}?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, in addition to if eq .CloudProviderName "azure"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? the reason why I disabled those repos due to some openssl certificates that are not consistent by some mirrors. After upgrading to use the Gold Access images for azure and then enabled repos from MS mirrors all worked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use GA image, does it mean this line can be removed then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because either cases whether you have a GA image or a custom one, rhui client would still try to access the repos. Thus this will end up with the same situation where rhui client certificates are expired and it would fail on all mirrors. I was expecting that updating yum update alone would actually update the certificate as well, however this is not the case for RHEL 8.x

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c4799ee2ff88a212fdfc99543d81b88f8d4c8213

@kubermatic-bot kubermatic-bot merged commit d340047 into kubermatic:master May 19, 2021
@moadqassem moadqassem deleted the fix-rhel-on-azure branch May 20, 2021 07:27
kron4eg pushed a commit to kron4eg/machine-controller that referenced this pull request Jun 2, 2021
@moadqassem @kron4eg
use the rhel ga instead of custom image on azure (kubermatic#975)
b74f682 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
kron4eg pushed a commit to kron4eg/machine-controller that referenced this pull request Jun 2, 2021
@moadqassem @kron4eg
use the rhel ga instead of custom image on azure (kubermatic#975)
4e87a85 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
kron4eg pushed a commit to kron4eg/machine-controller that referenced this pull request Jun 2, 2021
@moadqassem @kron4eg
use the rhel ga instead of custom image on azure (kubermatic#975)
04dbaa2 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
kron4eg pushed a commit to kron4eg/machine-controller that referenced this pull request Jun 2, 2021
@moadqassem @kron4eg
use the rhel ga instead of custom image on azure (kubermatic#975)
fc80b29 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
kron4eg pushed a commit to kron4eg/machine-controller that referenced this pull request Jun 2, 2021
@moadqassem @kron4eg
use the rhel ga instead of custom image on azure (kubermatic#975)
d2fb51a 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
kron4eg pushed a commit to kron4eg/machine-controller that referenced this pull request Jun 2, 2021
@moadqassem @kron4eg
use the rhel ga instead of custom image on azure (kubermatic#975)
70dd9b8 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
kubermatic-bot pushed a commit that referenced this pull request Jun 3, 2021
@kron4eg @moadqassem
[release/v1.27] Relaxed container runtime version (#992)
b4a6fe0 
* Relax container-runtime version spec

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* Update fixtures

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* use the rhel ga instead of custom image on azure (#975)

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

Co-authored-by: Moath Qasim <moad.qassem@gmail.com>
kubermatic-bot pushed a commit that referenced this pull request Jun 3, 2021
@kron4eg @moadqassem
[release/v1.24] Relaxed container runtime version (#991)
a9a09c4 
* Relax container-runtime version spec

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* Update fixtures

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* use the rhel ga instead of custom image on azure (#975)

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

Co-authored-by: Moath Qasim <moad.qassem@gmail.com>
kubermatic-bot pushed a commit that referenced this pull request Jun 10, 2021
@kron4eg @moadqassem
[release/v1.19] Relaxed container runtime version (#990)
883fc4a 
* Relax container-runtime version spec

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* Update fixtures

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* use the rhel ga instead of custom image on azure (#975)

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

* Fix RHEL on azure

Signed-off-by: Artiom Diomin <kron82@gmail.com>

Co-authored-by: Moath Qasim <moad.qassem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix RHEL image plan for e2e tests
3 participants
@moadqassem @kubermatic-bot @kron4eg